Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will not become hungry after eating #29938

Merged

Conversation

@KorGgenT
Copy link
Member

KorGgenT commented Apr 25, 2019

Summary

SUMMARY: Bugfixes "drinking water and eating a small amount will no longer cause hunger"

Purpose of change

Fixes #29917

Describe the solution

just a small edit to the if statement so that it will instead show "peckish" if you jsut ate, but have a certain range of volume in your stomach, which will downgrade to no string after 15 minutes.

also, made water and other drinks (not soup) not update last_ate

@dynoblaze99

This comment has been minimized.

Copy link

dynoblaze99 commented Apr 25, 2019

All cool

@dom4op

This comment has been minimized.

Copy link

dom4op commented Apr 26, 2019

also, made water and other drinks (not soup) not update last_ate

Not just water, but medicine too, please. Currently if I "eat" an aspirin it makes me hungry.

@KorGgenT

This comment has been minimized.

Copy link
Member Author

KorGgenT commented Apr 26, 2019

also, made water and other drinks (not soup) not update last_ate

Not just water, but medicine too, please. Currently if I "eat" an aspirin it makes me hungry.

i think someone else is working on that, so i won't stomp on their toes just yet

@Yunatan

This comment has been minimized.

Copy link
Contributor

Yunatan commented Apr 26, 2019

Aspirin will be not affected, because you actually eat aspirin. Only external medicine will be affected by my PR.

@kevingranade

This comment has been minimized.

Copy link
Member

kevingranade commented Apr 27, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/has-the-stomach-system-been-updated-what-does-peckish-mean/19855/4

@KorGgenT KorGgenT force-pushed the KorGgenT:more-hunger-display-tweaks branch from 6538695 to 6778aaf Apr 28, 2019
@kevingranade

This comment has been minimized.

Copy link
Member

kevingranade commented Apr 30, 2019

I'm not clear on the logic for having drinks not reset last_ate, for our uses they definitely have a tendency to suppress appetite.

@KorGgenT

This comment has been minimized.

Copy link
Member Author

KorGgenT commented Apr 30, 2019

it yeah, now that i think about it i was probably overreacting to the comments about all that stuff. i will leave in the rest of that logic though

@KorGgenT KorGgenT force-pushed the KorGgenT:more-hunger-display-tweaks branch from 6778aaf to 236b7ee Apr 30, 2019
@KorGgenT KorGgenT force-pushed the KorGgenT:more-hunger-display-tweaks branch from 236b7ee to c11d8d1 Apr 30, 2019
@kevingranade kevingranade merged commit 6de5d19 into CleverRaven:master Apr 30, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gorgon-ghprb Build started for merge commit.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.