Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upwill not become hungry after eating #29938
Conversation
KorGgenT
added
Info / User Interface
<Bugfix>
labels
Apr 25, 2019
This comment has been minimized.
This comment has been minimized.
dynoblaze99
commented
Apr 25, 2019
|
All cool |
This comment has been minimized.
This comment has been minimized.
dom4op
commented
Apr 26, 2019
Not just water, but medicine too, please. Currently if I "eat" an aspirin it makes me hungry. |
This comment has been minimized.
This comment has been minimized.
i think someone else is working on that, so i won't stomp on their toes just yet |
This comment has been minimized.
This comment has been minimized.
|
Aspirin will be not affected, because you actually eat aspirin. Only external medicine will be affected by my PR. |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: |
KorGgenT
force-pushed the
KorGgenT:more-hunger-display-tweaks
branch
from
6538695
to
6778aaf
Apr 28, 2019
This comment has been minimized.
This comment has been minimized.
|
I'm not clear on the logic for having drinks not reset last_ate, for our uses they definitely have a tendency to suppress appetite. |
This comment has been minimized.
This comment has been minimized.
|
it yeah, now that i think about it i was probably overreacting to the comments about all that stuff. i will leave in the rest of that logic though |
KorGgenT commentedApr 25, 2019
Summary
SUMMARY: Bugfixes "drinking water and eating a small amount will no longer cause hunger"Purpose of change
Fixes #29917
Describe the solution
just a small edit to the if statement so that it will instead show "peckish" if you jsut ate, but have a certain range of volume in your stomach, which will downgrade to no string after 15 minutes.
also, made water and other drinks (not soup) not update last_ate