Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd planters, allow plants to be grown on furniture #30225
Conversation
DracoGriffin
reviewed
May 4, 2019
|
I think the fact that you're willing to try and learn says a lot, and starting with a Draft PR was a smarter choice. Make sure to add the definitions for these new JSON flags in /doc/JSON_FLAGS.md. Did not review code --- will leave that to more experienced people. |
mlangsdorf
added
<Enhancement / Feature>
[C++]
Fields / Furniture / Terrain / Traps
labels
May 5, 2019
anothersimulacrum
marked this pull request as ready for review
May 5, 2019
anothersimulacrum
force-pushed the
anothersimulacrum:planters
branch
from
9cb81de
to
15b2076
May 5, 2019
This comment has been minimized.
This comment has been minimized.
|
As far as I can tell, everything works now, so I think this is ready for review. |
Night-Pryanik
reviewed
May 5, 2019
src/monattack.cpp Outdated
codemime
reviewed
May 5, 2019
src/activity_handlers.cpp Outdated
codemime
reviewed
May 5, 2019
src/mapdata.h Outdated
codemime
reviewed
May 5, 2019
src/iexamine.cpp Outdated
anothersimulacrum
added some commits
May 3, 2019
anothersimulacrum
force-pushed the
anothersimulacrum:planters
branch
5 times, most recently
from
bda3412
to
4439a03
May 11, 2019
ZhilkinSerg
self-assigned this
May 12, 2019
ZhilkinSerg
merged commit 9dbe860
into
CleverRaven:master
May 15, 2019
ZhilkinSerg
removed their assignment
May 15, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/what-are-some-things-that-should-be-in-the-cataclysm/18792/216 |
anothersimulacrum
referenced this pull request
May 25, 2019
Merged
Update hydroponics mod, change JSON for plant data #30853
anothersimulacrum
deleted the
anothersimulacrum:planters
branch
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
anothersimulacrum commentedMay 4, 2019
•
edited
Summary
SUMMARY: Content "Adds planters"Purpose of change
Resolves #29972
The game was missing options to grow plants anywhere but on
t_dirtDescribe the solution
Add two new fields
plant_transformandplant_baseto furnitureAdd 5 new flags -
GROWTH_SEED,SEEDLING,MATURE,HARVEST, andPLANTABLEAdjust
iexamine::plant_seed,iexamine::aggie_plant,map::grow_plant,activity_handlers::harvest_plot_do_turn,activity_handlers::plant_plot_do_turn,iexamine::harvest_plant, andmattack::eat_cropto use the new fields and flags to do their functionsAdd planter terrains
Amount of soil used in planter recipe based on calculations from this with dimensions of 3'x3'x18"
Describe alternatives you've considered
Leaving planting as only allowing terrain ( a simpler solution ), but that doesn't really address the issue
Additional context
I don't know C++, so I probably broke style rules and did things in a less than optimal manner
Thanks @curstwist for the planter furniture