Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete bio_furnace #30228

Merged
merged 1 commit into from May 5, 2019

Conversation

Projects
None yet
10 participants
@ymber
Copy link
Member

commented May 4, 2019

Summary

SUMMARY: Content "Obsolete internal furnace CBM"

Purpose of change

The internal furnace is comically impractical and the bionics system is moving away from such per #28273.
Closes #23262
Closes #29522

Describe the solution

Remove internal furnace from drop lists and professions. Currently existing furnaces will continue to function but no new ones can be acquired. All furnace functionality and references to it should be removed at the next compatibility break.

Describe alternatives you've considered

bio_furnace could be moved to crazy cataclysm.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Oh, what a great shitstorm, caused by this change, awaits us. "They removed Solar Panels! They nerfed to hell the Joint Torsion Rackets! And now they're removing Internal Furnace!"

bio_furnace could be moved to crazy cataclysm.

I guess this fantastic bionic will fit nicely there.

@HKMist

This comment has been minimized.

Copy link

commented May 4, 2019

It is really necessary to obsolete Internal Furnace?

Aside from the rebalance discussion on #28273, which don't have solid plan on how to implement the change, the removal of the system itself is not very clear. Comically impractical don't seem much a explanation here.

If the two bug of #23262 and #29522 is the main reason of this removal, and these bug can't be easily fix. Is some dirty fix like "adding filter to block anything have charge/magazine loaded to be consumable by internal furnace" possible to patch the hole?

@chaisawlajatang

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

I guess this fantastic bionic will fit nicely there.

Then almost every bionic is fantastic. Microprocessor, somehow connected with the neurons and helping the brain to... think? somehow? "Industrial-grade intestines and processors". Artificial night generator with very wibbley-wobbley work principle. Metabolic exchange, somehow (how?) transferring energy from the body to the battery (ATP transporter? NADP-related thing? there's no "energy" in the free form in the body). Integrated instruments, not interferring with fine finger and hand movements. And so on.

I'm not a fan of the internal furnace (I actually dislike it), but is this

is comically impractical

the decent reason to remove it? Seriously.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Microprocessors and mechanical intestines are plausible extrapolations of current tech. We already have cochlear implants, which are essentially microprocessors connected to your cochlea, and other artificial organs. Internal furnace has no such IRL equivalent.

@chaisawlajatang

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Cochlear implant (and the developing technology of 'artificial eyes') sends electrical impulses from the receptor into the brain. It's an infinitely simple device in comparison with a 'thinking processor'.
About artificial organs - artificial heart is just developing tech with a few successful cases of use. There are artificial 'lungs' and 'kidneys', yeah - big hefty stationary machines, so Cataclysm bionic implants are based on VERY extrapolated current tech.

@nexusmrsep

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Although I'm not against obsoleting internal furnace, it's one less method to gain power for other CBM systems. This reduces the variety, and thus some thoughts should be given towards potential replacement/ replacements. Some expansion towards battery system perhaps? A CBM with removable accumulators? Or something entirely different. External power storage device, like a solar backpack, but with a rechargable battery pack pluggable to your cable power system.

Another thought: remaining power generation/ supply CBMs should now be more common to make up for the decreases variety.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

I like your new bionics ideas, @nexusmrsep

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I think Cable Charger bionic should be the "default" power source that advertising agents of bionic companies should be recommending to their customers. All other types (microreactor, metabolic interchange, ethanol burner, and joint torsion rackets) are too invasive, too expensive (in pre-cataclysm prices) and require a lot of complex surgery. Cable Charger on the other way is just a cable with a plug that connects to the power storage - fast and easy to install.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Then almost every bionic is fantastic.

If it's purely fantastic (not "entirely physically possible or plausible, just in the future"), then we should rework the offending bionic or remove it altogether if it's not reworkable. We removed unrealistic bionics in the past, I don't see why can't we do it again.

@HKMist

This comment has been minimized.

Copy link

commented May 4, 2019

I don't think internal furnace is a well balance thing too but I don't want to discuss about realism/balance since i don't want to get warning of off topic again.

My doubt on this PR is the PR don't provide enough information on why ymber choose to obsolete internal furnace at this timing. Use #28273 as a reason is too weak since the whole discussion is around how to redesign the cbm system as a whole and don't touch much on individual cbm. And base on #23262 and #29522 is also weak since both are not game breaking(well,#29522 is balance breaking though) and seem somehow fixable, it seem a waste to choose remove instead of fixing/improve the whole infrastructure of internal furnace's code at this state.

And if the decision is base on realism/balance, it is too early to move into this step. Remove something may only need a day but making replacement can take months. It is always better to open discuss on how to balancing it or replace it with something first on removing content.

And I think if it really need to move, Aftershock seem more suitable. Crazy cataclysm is just too crazy for internal furnace.

@Rail-Runner

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Maybe pull it out into a mod, at least?

@kevingranade

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Feel free to add to a mod that doesn't care how ridiculous it is.

@kevingranade kevingranade merged commit 9b8472f into CleverRaven:master May 5, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@ymber ymber deleted the ymber:furnace branch May 5, 2019

@Ilysen

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

Was made aware of this through Discourse. I don't care enough to do it myself, but if someone wanted to put this into Aftershock, a whole lot of people would appreciate whoever did it.

@kevingranade

This comment has been minimized.

Copy link
Member

commented May 20, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/tips-tricks-and-newb-questions-reborn/16870/736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.