Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upConstruct a grave and bury your fallen companions or pets. #30281
Conversation
nexusmrsep
added some commits
May 6, 2019
This comment has been minimized.
This comment has been minimized.
I guess there could be all sorts of weird things happening if one will try to dig a tile with items on it. Maybe add a special case for graves? |
This comment has been minimized.
This comment has been minimized.
|
If by special case you mean adding graves as exception from the need of being empty then I'd be happy to do so. Or do you mean adding some extra special code handling grave contents during digging action handler? |
This comment has been minimized.
This comment has been minimized.
|
Maybe give a morale bonus to spiritual characters for doing that (but only in case actual corpse is buried)? |
This comment has been minimized.
This comment has been minimized.
|
@Rail-Runner good idea, I'll try to implement it tomorrow. |
This comment has been minimized.
This comment has been minimized.
This. |
This comment has been minimized.
This comment has been minimized.
This is a pretty recent addition (added for consistency in #29259). Before that, digging in presence of items was entirely possible. So I assume nothing terrible would happen if graves were excluded from this rule. |
This comment has been minimized.
This comment has been minimized.
|
It would be nice to also be able to inscribe last words or/and an epitaph. EDIT: Oh yes, and a log entry (kind of "buried someone"). |
This comment has been minimized.
This comment has been minimized.
|
Added the exemption for digging up / exhuming a new grave. Done a live test and nothing bad happend.
Great idea. Will look into it tomorrow. |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/tips-tricks-and-newb-questions-reborn/16870/715 |
This comment has been minimized.
This comment has been minimized.
|
Added morale bonus for spiritual characters when burying a proper body, some extra messages to indicate that, and a memorial log of the event. Needs some extra testing. Run out of time to do the epitaphs but tomorrow is also a day, so I'll get back to it. |
nexusmrsep
added
the
Crafting / Construction / Recipes
label
May 7, 2019
Night-Pryanik
reviewed
May 8, 2019
| for( item it : its ) { | ||
| if( it.is_corpse() ) { | ||
| if( it.get_corpse_name().empty() ) { | ||
| if( it.get_mtype()->has_flag( MF_HUMAN ) ) { |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
May 8, 2019
Member
It seems that if it's not human corpse, then do nothing? We were supposed to bury pets too, but in this case there's no morale changes nor sad words.
This comment has been minimized.
This comment has been minimized.
nexusmrsep
May 8, 2019
Author
Contributor
Actually if your pet animal was named, it falls under further check, that does not check if corpse was a human. I double checked if pet names carry on to their corpses and if it is recognized by the bury code. It is. Will fix the descriptions of morale gain to more general though.
So mourn all you want, but name your pet first.
I wish I could say that no in-game dog was harmed in making this feature but... c'est la vie.
Night-Pryanik
reviewed
May 8, 2019
src/construction.cpp Outdated
ZhilkinSerg
self-assigned this
May 8, 2019
nexusmrsep
added some commits
May 8, 2019
This comment has been minimized.
This comment has been minimized.
Done. Reused graffiti code for it. |
ZhilkinSerg
reviewed
May 10, 2019
.gitignore Outdated
ZhilkinSerg
reviewed
May 10, 2019
.gitignore Outdated
ZhilkinSerg
reviewed
May 10, 2019
.gitignore Outdated
ZhilkinSerg
reviewed
May 10, 2019
.gitignore Outdated
ZhilkinSerg
reviewed
May 10, 2019
.gitignore Outdated
ZhilkinSerg
reviewed
May 10, 2019
src/construction.cpp Outdated
ZhilkinSerg
reviewed
May 10, 2019
src/construction.cpp Outdated
ZhilkinSerg
reviewed
May 10, 2019
src/construction.cpp Outdated
ZhilkinSerg
reviewed
May 10, 2019
src/construction.cpp Outdated
ZhilkinSerg
reviewed
May 10, 2019
data/json/construction.json Outdated
ZhilkinSerg
reviewed
May 10, 2019
data/json/construction.json Outdated
ZhilkinSerg
reviewed
May 10, 2019
data/json/construction.json Outdated
ZhilkinSerg
reviewed
May 10, 2019
data/json/construction.json Outdated
ZhilkinSerg
reviewed
May 10, 2019
data/json/terrain.json Outdated
This comment has been minimized.
This comment has been minimized.
paulenka-aleh
commented
May 10, 2019
|
I wonder what could emerge from this grave when / if #28787 is implemented :) |

nexusmrsep commentedMay 6, 2019
•
edited
SUMMARY: Content "Construct a grave and bury your fallen companions or pets"Purpose of change
Follow-up after #28803, a highly requested feature.
Describe the solution
New construction type: Dig Grave and Bury Sealed Coffin
Impossible for now, because you can't dig in a place where items are located. @Night-Pryanik if its ok for mechanical reasons, can I exclude this terrain from being empty incan_dig_herecheck?Describe alternatives you've considered
Couple of other ways of implementation, but this was quite convenient and also fits my goal for this feature.
Additional context
I've reordered construction menu, since it doesn't sort by name, so options are now placed in following order for convenience: