Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-enable Internal Furnace CBM spawn in Aftershock mod #30409
Conversation
ifreund
added
[JSON]
Bionics
Mods
labels
May 11, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you! I f you want to put it in Bright Nights, too, the two mods aren't compatible in the first place, so it wouldn't cause any awful harm in doing so. |
This comment has been minimized.
This comment has been minimized.
I think it might be a good idea to make them compatible at some point. Just gonna check what conflicts. |
This comment has been minimized.
This comment has been minimized.
|
They both define the solar panels CBM, which makes them incompatible |
This comment has been minimized.
This comment has been minimized.
|
I propose even merging these two mods into one because as far as I'm concerned they have similar "the more sci-fi, the more fun" theme. |
This comment has been minimized.
This comment has been minimized.
|
Right now, Bright Nights' motif (as far as I can tell) is "much more futuristic Cataclysm", with stuff like civilian nuclear reactors; Aftershock's is "more of the same game, but things that aren't necessarily sensible.", with stuff like strange bionics and unique professions that are fun but unrealistic. I like having them separate as-is, but making them compatible would also be a great thing to do. (Granted, my say on it ultimately doesn't matter, but that's my |
ZhilkinSerg
self-assigned this
May 16, 2019
ZhilkinSerg
merged commit 663428a
into
CleverRaven:master
May 16, 2019
ZhilkinSerg
removed their assignment
May 16, 2019
Rail-Runner
deleted the
Rail-Runner:bio_furnace2
branch
May 17, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/tips-tricks-and-newb-questions-reborn/16870/737 |
Rail-Runner commentedMay 11, 2019
Summary
SUMMARY: Content "Re-enable Internal Furnace CBM spawn in Aftershock mod"Purpose of change
Prevent Internal Furnace CBM from being completely removed, instead moving it to Aftershock mod. For now, I only moved CBM item spawns, so as to avoid breaking existing saves. CBM item entry and bionic entry could be moved later at some point, once enough time passes.
Describe the solution
JSON editing.
Describe alternatives you've considered
Moving it to Bright Nights mod instead.
Additional context
None.