Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advanced_inventory: choose amount of charges on pickup. item.charges(): ...2 optional arguments for output precision. #3047

Merged
merged 3 commits into from Oct 18, 2013

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@atomicdryad @kevingranade
@atomicdryad
Copy link
Contributor

commented Sep 15, 2013

No description provided.

atomicdryad added some commits Sep 15, 2013

@atomicdryad
advanced_inventory: choose amount of charges on pickup. item.charges(… 
…): 2 optional arguments for output precision.
Loading status checks…
3b542c6
@atomicdryad
No point in asking if you can't pickup a single charge.
Loading status checks…
f22bfd5
@atomicdryad

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 15, 2013

post 0.8: refactoring movement code, possibly into an abstract 'move x to y' class that handles inv/map/vehicle/your weed stash/etc.

pre 0.8...I'd say the item.* stuff is safe....and required as changes to 'what is a volume' throw off functions that assume /= per unit for charges. (item.volume behaves the same by default)
@atomicdryad
Merge, and compensate for definition of itype.volume that is complete… 
…ly geschtonkenflapped:

Merge item::volume precision and unit arguments with
 item-with-charges-volume-scale-defined-by-max-charges-which-is-named-stack-size
behavior. precise_value now returns multiple of 1000, since the current maximum item::max_charges() / stack_size(.json)
is 200.
Loading status checks…
655c72c

@kevingranade kevingranade merged commit 655c72c into CleverRaven:master Oct 18, 2013
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.