Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upInvlet fix attempt #1352143-a: Don't initialize item charges in all cases. No comment. #3051
Conversation
atomicdryad
added some commits
Sep 15, 2013
This comment has been minimized.
This comment has been minimized.
|
I need:
|
This comment has been minimized.
This comment has been minimized.
|
I can't make sense of this, I need an explanation of what it's supposed to do. |
This comment has been minimized.
This comment has been minimized.
|
item.charges / .invlets / .item_counter were not initialized in all cases prior to init() , this is a revert to pre-init behavior for those cases, in a hair pulling attempt to smash bug with thrice dammed invlets. item_counter getting clobbered in particular |
This comment has been minimized.
This comment has been minimized.
|
So you have no idea why, you're just pseudo reverting something that broke |
This comment has been minimized.
This comment has been minimized.
|
Yep. Since nobody wanted to test, and reverting to -exact- previous behavior is apparently verboten, close |
atomicdryad
closed this
Sep 28, 2013
atomicdryad
deleted the
atomicdryad:invletsinvletsinvletsarghshootmeinthehead
branch
Sep 28, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
atomicdryad commentedSep 15, 2013
No description provided.