Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded framework for vehicle horns #3080
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please put new enum entries at the end; If they're put in the middle it breaks save compatibility. This won't be an issue sooon |
This comment has been minimized.
This comment has been minimized.
|
Wow, you're so fast! Good job! |
This comment has been minimized.
This comment has been minimized.
CinghialeCdda
commented
Sep 17, 2013
|
Semis use big airhorns, painfully loud up close. They should almost be as loud as pistol shot. |
This comment has been minimized.
This comment has been minimized.
|
Alright, truck horns (which are only used by cargo trucks and semis) are louder than a sound described as a "disturbing scream". So that should do it. :p The vehicle horns were moved to the end of the parts enum, and I cleaned up the code a bit. Horn honking is now in its own function, so horns can potentially be honked by something other than the player (zombies crawling through vehicle interiors?) I should probably add in support for multiple horns, maybe making their sounds overlap to produce a louder one. I'll need to think about that. But this is in a merge-able state right now. |
This comment has been minimized.
This comment has been minimized.
|
This may have been put into conflict with a pr I made earlier, do you mind if I correct while merging? |
Gatleos commentedSep 17, 2013
(See issue #3070)
Alright, this is a basic framework I threw together for vehicle horns. So far we have:
TODO:
Right now all cars use the same horn. Semis should probably use a louder one.Done!Any other ideas/suggestions?