Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNew Shoes! Heelys! #30956
Conversation
Positronic-Girl
added some commits
May 29, 2019
KorGgenT
added
[JSON]
Items / Item Actions / Item Qualities
labels
May 29, 2019
AMurkin
reviewed
May 29, 2019
data/json/items/armor/boots.json Outdated
This comment has been minimized.
This comment has been minimized.
|
These need a distinctly different set of performance characteristics compared to dedicated skates. They aren't as fast or as maneuverable as skates, and I suspect the balance issues are worse. |
Night-Pryanik
reviewed
May 29, 2019
| "type": "ARMOR", | ||
| "name": "pair of roller shoes (off)", | ||
| "name_plural": "pairs of roller shoes (off)", | ||
| "description": "A pair of sneakers with wheels, currently, the wheels are hidden.", |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
May 29, 2019
Member
| "description": "A pair of sneakers with wheels, currently, the wheels are hidden.", | |
| "description": "A pair of sneakers with wheels, currently the wheels are hidden.", |
Night-Pryanik
reviewed
May 29, 2019
data/json/items/armor/boots.json Outdated
ZhilkinSerg
self-assigned this
May 29, 2019
This comment has been minimized.
This comment has been minimized.
Yeah, this was pointed out in the discord about the characteristics, but I had no idea how to edit it in such a way that their performance would be different from skates. |
This comment has been minimized.
This comment has been minimized.
|
Figured out how to edit C++ with some help and suggestion, adding the new flags I made and going to edit the base post to reflect these changes |
Positronic-Girl
added some commits
May 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Also please don't avoid Trademarked terms, if they're commonly called Heelys, call them that. |
This comment has been minimized.
This comment has been minimized.
Alright thank you! I edited my top post to include the changes, and yeah, I dunno if I should or not have avoided the trademarked terms cause I didn't know y'all stance on using trademarked terms... I edited it to have a more recognizable name now. |
Positronic-Girl
changed the title
New Shoes! Roller Shoes!
New Shoes! Heelys!
May 30, 2019
KorGgenT
reviewed
May 30, 2019
src/player.cpp Outdated
Positronic-Girl
and others
added some commits
May 30, 2019
AMurkin
reviewed
May 30, 2019
| if( on_road ) { | ||
| movecost *= 0.85f; | ||
| } else { | ||
| movecost *= 1.55f; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Positronic-Girl
May 30, 2019
•
Author
Contributor
Ah, I was gonna just change it to 1.1 after it was pointed out to me that was really steep, thank you though, and thanks for all your help so far :3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
After some discussion with Kevin, I reduced the cost of movement on non-flat terrain to 1.1 from 1.55 Also these videos were brought up in the discord, and I'm gonna post em here cause I was suggested too, and they seem to be interesting, at least for future reference or so. https://www.youtube.com/watch?v=kVbtVQ2BXvs Here are heelys that are being used in a flat surface https://www.youtube.com/watch?v=OZC5W5ek-4U This is also apparently a DIY motorized heely? which, if the possibility is ever coded in the game, could be a "survivor" version of heelys maybe? |
Night-Pryanik
reviewed
May 30, 2019
| "warmth": 20, | ||
| "material_thickness": 2, | ||
| "use_action": { "type": "transform", "target": "roller_shoes_off", "msg": "You pop the wheels back in.", "moves": 500 }, | ||
| "flags": [ "VARSIZE", "HEELIES", "ROLLER_ONE", "REQUIRES_BALANCE" ] |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
May 30, 2019
Member
Why do you need two flags - HEELIES and ROLLER_ONE? I'm pretty sure one is enough.
This comment has been minimized.
This comment has been minimized.
Positronic-Girl
May 30, 2019
Author
Contributor
Fair, this was set up in such a way that roller_one and heelies would be separate, as they do separate things which is
Roller One: it modifies the shoe itself, changing the speed
Heelies: its just a stand-alone flag that modifies requires_balance so that any item that has it changes it so the balance has something added to it to make the item less unstable.
I figured I would keep them separate in case someone might need the use of heelies but not roller_one and vice versa, but if bloat is a worry, then I can probably remove heelies and change the flag in requires_balance from heelies to roller_one.
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
May 30, 2019
Member
Yeah, please leave only the necessary stuff.
Also, please add a documentation for your new flag in json_flags.md.
This comment has been minimized.
This comment has been minimized.
Positronic-Girl
May 30, 2019
Author
Contributor
I thought I did? Strange, I guess it didn't save, let me remove heelies flag and then re-add the flag to json_flags
This comment has been minimized.
This comment has been minimized.
Positronic-Girl
May 30, 2019
Author
Contributor
Alright, I removed HEELIES flag, as well as not only adding ROLLER_ONE to json_flags, but ROLLER_QUAD and ROLLER_INLINE as well, as for some reason they are missing.
Positronic-Girl
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
|
So these mainly change the stamina dynamics? As in, about the same speed as running, but allow you to coast, so changing your energy expenditure. Right? |
This comment has been minimized.
This comment has been minimized.
No, it is slightly faster than running, as linked in the above video, but isn't as fast as rollerskates. I don't think I could do coasting right now, as it might require a lot of C++ coding. |
kevingranade
merged commit 2d296d8
into
CleverRaven:master
May 31, 2019
ZhilkinSerg
removed their assignment
May 31, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/suggestions-for-new-items/20697/14 |
Positronic-Girl commentedMay 29, 2019
•
edited
Summary
SUMMARY: Content "Adds new armor "heelys"Purpose of change
Adding a new type of shoes that act like convertible roller skates, going from sneakers to roller skates, and back.Describe the solution
It adds two new items, roller_shoes_off and roller_shoes_on, as well as editing some item groups so it can spawn in. Thanks to some help from other people, the shoes take around 500 moves to transform as well as displaying a message.
The roller shoes (off) are essentially just sneakers, nothing special there but the roller shoes (on) are roller skates that are essentially similar to sneakers, except they have the ability to roll like roller skates, they lack the waterproof flag that roller skates have, but still have the balance flag.
EDIT:
After Kevin's suggestions, I made a new flag "ROLLER_ONE" that reduces the speed bonus to 0.85 and the speed penalty on non-flat terrain to 1.1, as well as adding a flag to "REQUIRES_BALANCE" with the flag "HEELIES" that modify the dice roll by +2 I believe? As well as changing the name from "roller shoes" to a more recognizable name of "heelys" I also removed steel from the materials list, as it seemed like the steel in these wouldn't be enough to even be scrap.