Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate cataclysm solutions #31160
Conversation
KorGgenT
added
the
OS: Windows
label
Jun 5, 2019
KorGgenT
requested a review
from
ZhilkinSerg
Jun 5, 2019
ZhilkinSerg
merged commit 7dee315
into
CleverRaven:master
Jun 6, 2019
KorGgenT
deleted the
KorGgenT:VS-solution-update
branch
Jun 14, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/problem-compiling-on-windows-for-visual-studio-2019/20425/9 |
AlexJBlair
referenced this pull request
Jun 20, 2019
Merged
Fix Visual Studio toolset version in compilation instructions #31640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KorGgenT commentedJun 5, 2019
•
edited
Summary
SUMMARY: nonePurpose of change
Describe the solution
update platform toolset on Cataclysm-App, Cataclysm-Lib and Cataclysm-Tests from v140 to v141
Alternatives
fix the constexpr to only have one return statement