Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for reading time with 1s turns #31336
+1
−1
Conversation
Leosky
added some commits
Jun 11, 2019
ZhilkinSerg
self-assigned this
Jun 11, 2019
kevingranade
merged commit 29f373e
into
CleverRaven:master
Jun 11, 2019
ZhilkinSerg
removed their assignment
Jun 12, 2019
This comment has been minimized.
This comment has been minimized.
|
I noticed reading speed in the character windows is way too high, i will investigate this later today |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/600-reading-time-help-please/20341/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Leosky commentedJun 11, 2019
Summary
SUMMARY: Bugfixes "Fix for the too fast reading speed"Purpose of change
Fix for #31248
Describe the solution
This issue come from reading being move speed based, as they are now based on one second turns its six times shorter. To fix it asap i just multiplied it by six.
Describe alternatives you've considered
I considered switching to time based action but my understanding of time mechanics being limited for now I just PR this quick fix until I switch reading mechanic to time based action as requestion by anothersimulacrum and esotericist when I understand them enough to not add side effects.
Additional context
I tested in a test game and the reading times displayed and effectives where correlating the JSON reading times.