Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upPlayer overmap auto-travel #31786
Conversation
Night-Pryanik
reviewed
Jun 24, 2019
src/activity_handlers.cpp Outdated
Night-Pryanik
reviewed
Jun 24, 2019
src/activity_handlers.cpp Outdated
This comment has been minimized.
This comment has been minimized.
|
Screenshots or, even better, gif would be helpful. |
This comment has been minimized.
This comment has been minimized.
https://gfycat.com/classicesteemedguineapig A gif of the selection of the route and the auto-travel. Bear in mind my laptop is an absolute potato, and recording and travelling in cata looks slow. |
This comment has been minimized.
This comment has been minimized.
|
Oh, this is absolutely marvelous! |
ifreund
reviewed
Jun 24, 2019
src/player.h Outdated
ifreund
reviewed
Jun 24, 2019
data/raw/keybindings.json Outdated
BevapDin
reviewed
Jun 24, 2019
src/overmap_ui.cpp Outdated
BevapDin
reviewed
Jun 24, 2019
src/overmap_ui.cpp Outdated
BevapDin
reviewed
Jun 24, 2019
src/overmap_ui.cpp Outdated
jbytheway
reviewed
Jun 24, 2019
src/overmap_ui.cpp Outdated
This comment has been minimized.
This comment has been minimized.
|
Fixed some pathing problems, and the prompt to continue travelling when mosnter spotted. It's much faster. |
This comment has been minimized.
This comment has been minimized.
|
It keeps stopping after what looks like reaching the next submap. |
This comment has been minimized.
This comment has been minimized.
It's not doing that for me... any particular situation you were in when it stops moving? any potential difficulties in pathing the terrain perhaps? or nearby monsters? |
davidpwbrown
force-pushed the
davidpwbrown:player_overmap_travel
branch
from
4d1ba53
to
772b46a
Jun 26, 2019
davidpwbrown
added some commits
Jun 26, 2019
davidpwbrown
force-pushed the
davidpwbrown:player_overmap_travel
branch
from
772b46a
to
25e87d1
Jun 26, 2019
This comment has been minimized.
This comment has been minimized.
|
This looks really cool! |
This comment has been minimized.
This comment has been minimized.
|
I was just auto-traveling down a road, sometimes on it and sometimes not on it, there were no monsters or other threats and nothing in particular was happening to the player, so I'm not clear what would have cancelled it, but it was very persistent. It's possible I just had a bad merge with other stuff I was testing at the same time, so if I re test and that doesn't happen we can proceed. |
This comment has been minimized.
This comment has been minimized.
|
This was breaking in iso tiles mode. Don't ask me why, no idea. |
kevingranade
merged commit b8698af
into
CleverRaven:master
Jun 27, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/player-overmap-autotravel/20572/1 |
davidpwbrown commentedJun 23, 2019
•
edited
Summary
SUMMARY: Features "Player overmap auto-travel"Purpose of change
Getting annoyed at the long-distance travelling back to base, I thought it might be cool to get the player to do it for you automatically.
Describe the solution
Leverages activities set_destination and player automove functionality.
Gets the omt pos from the overmap UI, where you can preview the route. ( press W to select and again to confirm )
THe player will then do an automove route there.
Similar to the automove, it will cancel when enemies are spotted.
This could probably be tweaked better to allow the player to keep movng even though enemies are visible, otherwise it is slightly less convenient, unless the path is known to be safe.
Describe alternatives you've considered
A proper absolute co-ord pathing system would be nice.
What I did here instead was find the next omt along , so its still inbounds and get its centre point, then path again when reaching that point, and so on.
This means it probably could be a whole lot faster.
Would welcome feedback on this area.
Additional context
N/A