Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix 'vehicle runs over something' spam #31864
+4
−0
Conversation
kevingranade
merged commit 5fc8138
into
CleverRaven:master
Jun 26, 2019
OrenAudeles
deleted the
OrenAudeles:run_over_spam
branch
Jun 26, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/insert-tire-here-runs-over-something-xevery-wheel/20556/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
OrenAudeles commentedJun 26, 2019
Summary
SUMMARY: Bugfixes "Fix 'vehicle runs over something' spam"Purpose of change
Fixes #31836 - Vehicle tires runs over something message log spam.
Bug introduced in #31734
Describe the solution
If there is no trap then
trap_id twill betr_null. We can test for this and exit early.