Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix compiling error introduced in #31789 #31875
+1
−0
Conversation
ifreund
added
<Bugfix>
Code: Build
OS: Windows
[C++]
labels
Jun 26, 2019
ifreund
approved these changes
Jun 26, 2019
|
Thanks for fixing this, not sure why it didn't error on non-windows build systems. |
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/insert-tire-here-runs-over-something-xevery-wheel/20556/10 |
This comment has been minimized.
This comment has been minimized.
|
Thanks a bunch for fixing this, sorry i didn't notice it when compiling myself. |
ZhilkinSerg
merged commit c88b7db
into
CleverRaven:master
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Maddremor commentedJun 26, 2019
Summary
SUMMARY: Bugfixes "Fix compiling error introduced in #31789"Purpose of change
Got compiling errors
magic_teleporter_list.cpp:(.text+0x1ff5): undefined reference to `avatar* game::critter_at<avatar>(tripoint const&, bool)'after #31789 got merged.Describe the solution
ifreund told me to add a line. Said line worked.
Describe alternatives you've considered
Waiting for someone else to get the same issue and fix it.