Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Vehicles not working on worlds with disabled z-levels #31920
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/vehicles-cant-accelerate/20574/4 |
kevingranade
merged commit 1bb9579
into
CleverRaven:master
Jun 27, 2019
ZhilkinSerg
added
<Bugfix>
[C++]
Z-levels
labels
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidpwbrown commentedJun 27, 2019
Summary
SUMMARY: Bugfixes "Fix Vehicles not working on worlds with disabled z-levels"Purpose of change
Fixes #31919
Describe the solution
Recent change to improve performance of vehicle cache wasnt looping properly on worlds with z-levels disabled, and so didnt add any vehicles to the vehicle cache, at all.
Describe alternatives you've considered
N/A
Additional context
N/A