Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upInsure long actions never excessively drain stamina #31951
+11
−11
Conversation
nexusmrsep
referenced this pull request
Jun 29, 2019
Closed
Fail-safes for stamina drop in pulping and butchering #31921
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/smashing-blindness-9231/20610/2 |
ZhilkinSerg
added
[C++]
Character / Player
Game: Balance
labels
Jun 30, 2019
ZhilkinSerg
self-assigned this
Jun 30, 2019
ZhilkinSerg
merged commit aef757f
into
CleverRaven:master
Jun 30, 2019
ZhilkinSerg
removed their assignment
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedJun 29, 2019
Summary
SUMMARY: None
Purpose of change
This is an alternative to #31921
The underlying problem is that long actions can critically impact stamina, and seem to lead to a death spiral.
Describe the solution
Adjust the trigger for the winded to only occur if current stamina is 20% or less of max stamina.
Add code in player_activity::do_turn() to "pass the turn" if stamina is lower than 33% of max stamina. Stamina is recovered elsewhere in the code.
As a result, stamina-consuming tasks proceed rapidly in bursts if the player is initially in good condition, but longer duration tasks become limited by stamina recovery rate.