Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insure long actions never excessively drain stamina #31951

Merged

Conversation

Projects
None yet
2 participants
@kevingranade
Copy link
Member

commented Jun 29, 2019

Summary

SUMMARY: None

Purpose of change

This is an alternative to #31921
The underlying problem is that long actions can critically impact stamina, and seem to lead to a death spiral.

Describe the solution

Adjust the trigger for the winded to only occur if current stamina is 20% or less of max stamina.
Add code in player_activity::do_turn() to "pass the turn" if stamina is lower than 33% of max stamina. Stamina is recovered elsewhere in the code.
As a result, stamina-consuming tasks proceed rapidly in bursts if the player is initially in good condition, but longer duration tasks become limited by stamina recovery rate.

@kevingranade

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/smashing-blindness-9231/20610/2

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 30, 2019

@ZhilkinSerg ZhilkinSerg merged commit aef757f into CleverRaven:master Jun 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg removed their assignment Jun 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.