Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdditions to snippets for lore and flavor #32289
Conversation
rtizzy
changed the title
Note additions for lore and flavor
Additions to snippets for lore and flavor
Jul 10, 2019
I-am-Erk
requested changes
Jul 10, 2019
|
Make sure to leave double spaces after periods. I object a bit to the assertion that "the game currently lacks any significant in game lore." I've added literally thousands of lines of lore via npc backgrounds and conversations. |
data/json/snippets/snippets.json Outdated
data/json/snippets/snippets.json Outdated
data/json/snippets/snippets.json Outdated
data/json/snippets/snippets.json Outdated
data/json/snippets/snippets.json Outdated
I-am-Erk
added
[JSON]
Items / Item Actions / Item Qualities
Lore
labels
Jul 10, 2019
This comment has been minimized.
This comment has been minimized.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/expanding-lore-and-detail-update-8-4-13/334/79 |
rtizzy
added some commits
Jul 10, 2019
rtizzy
reviewed
Jul 10, 2019
|
Periods have had double spaces added. |
This comment has been minimized.
This comment has been minimized.
|
Pushed change to fix formatting issues that were causing the build to fail. Should pass now. |
rtizzy
added some commits
Jul 10, 2019
I-am-Erk
reviewed
Jul 11, 2019
|
Changes look good, thank you. There are still a bunch of punctuation errors, like a lot of lines ending with ``. "` - give it a bit of a read through, it's most of the file because of the find and replace I think. |
I-am-Erk
self-requested a review
Jul 11, 2019
Night-Pryanik
reviewed
Jul 13, 2019
| 3. SEEK SHELTER IN THE BASEMENT. \n\ | ||
| 4. USE PROVIDED GAS MASKS. \n\ | ||
| 5. AWAIT FURTHER INSTRUCTIONS. \n\ | ||
| 1. PLEASE REMAIN CALM \n\ |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Jul 13, 2019
Member
| 1. PLEASE REMAIN CALM \n\ | |
| 1. PLEASE REMAIN CALM. \n\ |
rtizzy commentedJul 10, 2019
•
edited
Summary
SUMMARY: Content "Additional snippets for lore"Purpose of change
#24278
Partial remediation of above mentioned issue
Describe the solution
Simply adds additional notes to the game to improve flavor and lore.
Additional context
This was a project originally started in 2013.
The game currently lacks any significant in game lore.
The series of PRs related to this issue are intended to improve and increase the amount of lore available to the player character in the game.
These PRs would be far more effective if the following issue is addressed.
#28853
In short: Allowing a more immersive way of viewing in game items such as notes, journals, and newspapers.