Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to snippets for lore and flavor #32289

Open
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@rtizzy
Copy link
Contributor

commented Jul 10, 2019

Summary

SUMMARY: Content "Additional snippets for lore"

Purpose of change

#24278

Partial remediation of above mentioned issue

Describe the solution

Simply adds additional notes to the game to improve flavor and lore.

Additional context

This was a project originally started in 2013.

The game currently lacks any significant in game lore.

The series of PRs related to this issue are intended to improve and increase the amount of lore available to the player character in the game.

These PRs would be far more effective if the following issue is addressed.

#28853

In short: Allowing a more immersive way of viewing in game items such as notes, journals, and newspapers.

@rtizzy rtizzy changed the title Note additions for lore and flavor Additions to snippets for lore and flavor Jul 10, 2019

@I-am-Erk
Copy link
Contributor

left a comment

Make sure to leave double spaces after periods.

I object a bit to the assertion that "the game currently lacks any significant in game lore." I've added literally thousands of lines of lore via npc backgrounds and conversations.

Show resolved Hide resolved data/json/snippets/snippets.json Outdated
Show resolved Hide resolved data/json/snippets/snippets.json Outdated
Show resolved Hide resolved data/json/snippets/snippets.json Outdated
Show resolved Hide resolved data/json/snippets/snippets.json Outdated
Show resolved Hide resolved data/json/snippets/snippets.json Outdated
@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/expanding-lore-and-detail-update-8-4-13/334/79

@rtizzy
Copy link
Contributor Author

left a comment

Periods have had double spaces added.

@rtizzy

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Pushed change to fix formatting issues that were causing the build to fail. Should pass now.

@I-am-Erk
Copy link
Contributor

left a comment

Changes look good, thank you. There are still a bunch of punctuation errors, like a lot of lines ending with ``. "` - give it a bit of a read through, it's most of the file because of the find and replace I think.

@I-am-Erk I-am-Erk self-requested a review Jul 11, 2019

3. SEEK SHELTER IN THE BASEMENT. \n\
4. USE PROVIDED GAS MASKS. \n\
5. AWAIT FURTHER INSTRUCTIONS. \n\
1. PLEASE REMAIN CALM \n\

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Jul 13, 2019

Member
Suggested change
1. PLEASE REMAIN CALM \n\
1. PLEASE REMAIN CALM. \n\
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.