Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds json-moddable tool groups #3355
Conversation
Gatleos
added some commits
Sep 29, 2013
This comment has been minimized.
This comment has been minimized.
|
Could work better by setting the groups from within the itype entry, then autogenerating the group mapping after itype_init. That way, adding a new tool only requires editing one file. |
This comment has been minimized.
This comment has been minimized.
|
Just remember that some recipes can only use certain tools from those groups. You can't really blacksmith with a rock or hatchet - gotta have a proper hammer and such. |
This comment has been minimized.
This comment has been minimized.
|
@Rivet-the-Zombie Yeah, I left the smithing recipes alone. It would be easy to just add another tool group that only includes tools suitable for metalworking. @atomicdryad That is a good idea, I just wanted all the definitions in one place. |
This comment has been minimized.
This comment has been minimized.
|
I'm going to try to implement an alternative to this with the definition in the tool files themselves. Will probably use some of the same code though! |
This comment has been minimized.
This comment has been minimized.
|
@GlyphGryph Not much of this code would have to be changed to do that. I can just make a quick PR if you don't want to do it yourself. |
This comment has been minimized.
This comment has been minimized.
|
Okay, so - I ended up doing something pretty different, since I've had the tool quality levels thing sitting on my plate for a while, and a different implementation of THIS made THAT outright trivial. See: |
Gatleos
closed this
Oct 4, 2013
Gatleos
deleted the
Gatleos:toolgroup
branch
Oct 4, 2013
This comment has been minimized.
This comment has been minimized.
|
Thanks for kicking my ass into gear, though. |
Gatleos commentedSep 29, 2013
(Suggestion thread: http://smf.cataclysmdda.com/index.php?topic=3501.0)
This first PR adds a system to read in an arbitrary number of tool groups, which can be substituted for normal tools in recipe entries. On the crafting menu you can switch between viewing the condensed tool list with groups displayed, and viewing the full list of tools.
No tool groups have been added yet.