Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds json-moddable tool groups #3355

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@Gatleos
Copy link
Contributor

commented Sep 29, 2013

(Suggestion thread: http://smf.cataclysmdda.com/index.php?topic=3501.0)
This first PR adds a system to read in an arbitrary number of tool groups, which can be substituted for normal tools in recipe entries. On the crafting menu you can switch between viewing the condensed tool list with groups displayed, and viewing the full list of tools.

No tool groups have been added yet.

Gatleos added some commits Sep 29, 2013

Adds "pounding tool" group and updates recipes
Updates a ton of recipes to use the tool_pounding tool group, fixing a
lot of redundant or erroneous tool lists.
@atomicdryad

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2013

Could work better by setting the groups from within the itype entry, then autogenerating the group mapping after itype_init. That way, adding a new tool only requires editing one file.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Sep 29, 2013

Just remember that some recipes can only use certain tools from those groups.

You can't really blacksmith with a rock or hatchet - gotta have a proper hammer and such.

@Gatleos

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2013

@Rivet-the-Zombie Yeah, I left the smithing recipes alone. It would be easy to just add another tool group that only includes tools suitable for metalworking.

@atomicdryad That is a good idea, I just wanted all the definitions in one place.

@GlyphGryph

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2013

I'm going to try to implement an alternative to this with the definition in the tool files themselves. Will probably use some of the same code though!

@Gatleos

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2013

@GlyphGryph Not much of this code would have to be changed to do that. I can just make a quick PR if you don't want to do it yourself.

@GlyphGryph

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2013

Okay, so - I ended up doing something pretty different, since I've had the tool quality levels thing sitting on my plate for a while, and a different implementation of THIS made THAT outright trivial.

See:
#3438

@Gatleos Gatleos closed this Oct 4, 2013

@Gatleos Gatleos deleted the Gatleos:toolgroup branch Oct 4, 2013

@GlyphGryph

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2013

Thanks for kicking my ass into gear, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.