Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sterilizing CBM behind the scene logic #33902

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@Fris0uman
Copy link
Contributor

commented Sep 8, 2019

Summary

SUMMARY: Infrastructure "Simplify sterilizing CBM behind the scene logic"

Purpose of change

Failing to pack CBM becomes immediatly apparent
Unpacked CBM are no longer sterile for 1s after coming out of the autoclave.

Describe the solution

Get rid of the faulty package logic
Get rid of the "sterile" var, CBM are now sterile forever or not at all.

Describe alternatives you've considered

Additional context

@kevingranade

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/some-cbms-become-non-sterile-when-removed-from-autoclave/21280/5

src/iuse.cpp Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
Fris0uman and others added 2 commits Sep 9, 2019
Apply suggestions from code review
Co-Authored-By: Alexey Mostovoy <amurkin1988@yandex.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
fix

@ZhilkinSerg ZhilkinSerg merged commit 3b10f41 into CleverRaven:master Sep 10, 2019

5 checks passed

Build
Details
JSON style check
Details
Validate PR
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Fris0uman Fris0uman deleted the Fris0uman:pouch branch Sep 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.