Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basecamp NPC mission crash fix #33925

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@davidpwbrown
Copy link
Member

commented Sep 9, 2019

Summary

SUMMARY: Bugfixes "Basecamp NPC mission crash fix"

Purpose of change

Fixes #33869

Describe the solution

I made all NPCs dismount when they started a mission.
I forgot to actually check if they were riding, or even add an early return to the dismount function if its called when not riding.
So ive added a check for is riding before dismounting, and an early return in dismount() as a second level of protection.

Describe alternatives you've considered

N/A

Additional context

N/A

@kevingranade

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/crash-when-assigning-follower-to-task-at-faction-camp/21269/9

@ZhilkinSerg ZhilkinSerg merged commit c5ee4d4 into CleverRaven:master Sep 10, 2019

5 checks passed

Build
Details
JSON style check
Details
Validate PR
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidpwbrown davidpwbrown deleted the davidpwbrown:camp_riding_fix branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.