Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumper cable not working without bio_cable CBM #33947

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@anothersimulacrum
Copy link
Contributor

commented Sep 10, 2019

Summary

SUMMARY: Bugfixes "Fix jumper cable not working for players without the cable charger CBM"

Purpose of change

It was impossible to do anything but detach a jumper cable from a vehicle once you had attached it if you did not have the cable charger CBM.
Resolves #33805

Describe the solution

Move the menu entry for attaching a cable from the block that appears when you only have a cable charger CBM to above that.

Describe alternatives you've considered

There seems to be some other odd behavior with the cable charger CBM and jumper cables, but none of it seems to impact functionality. I considered fixing it, but decided that was out of the scope of this PR.

Testing

Tested by spawning in a jumper cable and two vehicles. I was able to attach it to the first vehicle and then the second with this change applied, but without I was unable to do anything but detach it after attaching it to one vehicle.

I then debug installed the cable charger CBM and verified that I could still attach the jumper cable to both vehicles with that, which I was able to do.

Additional Context

Summary appears to have failed because I put a period after it - whoops!

Fix jumper cable not working without bio_cable CBM
The jumper cable was not working - you could attach it to a vehicle, but
past that, without the cable charger CBM, you could not do anything but
detach it from that vehicle. This changes it to allow you to attach it
to a vehicle without having the CBM.
@kevingranade

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/jumper-cables-not-working/21296/2

@ZhilkinSerg ZhilkinSerg merged commit 8c2d6d8 into CleverRaven:master Sep 10, 2019

3 of 5 checks passed

Validate PR
Details
Build
Details
JSON style check
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@anothersimulacrum anothersimulacrum deleted the anothersimulacrum:jumper-cable branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.