Migrate move mode and related code from player #34762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
[C++]
|
Forgot to do an SDL build before pushing, should be fixed now. |
- Hoist the move_mode variable up to character since NPCs should crouch and run someday - Drop UI-related code down to avatar - Serialize/deserialize move_mode in the character functions - Tweak related code to accomadate the changes
This fixes compilation of SDL builds
ifreund
force-pushed
the
move-mode-refactor
branch
from
41dd9c2
to
ab3b1c5
Compare
|
Rebased to avoid conflict with recently merged #34770 |
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Oct 22, 2019
* Migrate move mode and related code from player - Hoist the move_mode variable up to character since NPCs should crouch and run someday - Drop UI-related code down to avatar - Serialize/deserialize move_mode in the character functions - Tweak related code to accomadate the changes * Migrate get_overlay_ids() to Character This fixes compilation of SDL builds
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Migrate move mode and related code from player - Hoist the move_mode variable up to character since NPCs should crouch and run someday - Drop UI-related code down to avatar - Serialize/deserialize move_mode in the character functions - Tweak related code to accomadate the changes * Migrate get_overlay_ids() to Character This fixes compilation of SDL builds
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Migrate move mode and related code from player - Hoist the move_mode variable up to character since NPCs should crouch and run someday - Drop UI-related code down to avatar - Serialize/deserialize move_mode in the character functions - Tweak related code to accomadate the changes * Migrate get_overlay_ids() to Character This fixes compilation of SDL builds
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Migrate move mode and related code from player - Hoist the move_mode variable up to character since NPCs should crouch and run someday - Drop UI-related code down to avatar - Serialize/deserialize move_mode in the character functions - Tweak related code to accomadate the changes * Migrate get_overlay_ids() to Character This fixes compilation of SDL builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Migrate move mode and related code from player."
Purpose of change
Work towards #34721
Describe the solution
Describe alternatives you've considered
Trying to clean up the code at the same time. Decided that it would be best to stick to the goal of killing the player class though.
Testing