Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Fix for vehicle parts not displaying properly #3561

Merged
merged 2 commits into from Oct 21, 2013

Conversation

Projects
None yet
5 participants
@GalenEvil
Copy link
Contributor

commented Oct 10, 2013

  • Note: Will require tileset config files to be updated to the jsonized vehicle_part id values along with a "vp_" prefix to reduce potential conflicts later.

Have a compatible json and this works nicely :D

Also of note: This works with Tsu's tileset at the moment, and Deon has been informed of the necessary changes as well. Hoder was informed, but has since discontinued development on his tileset which sucks.

@Abalieno

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2013

I could test this if it was merged.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Oct 12, 2013

Preferably we like to test things before merging them. :P

That said if you are compiling your own you can always just do "git pull https://github.com/GalenEvil/Cataclysm-DDA-1.git VPart_Tile_Fix" to pull this in to your own version prior to compiling to test it.

GalenEvil added some commits Oct 10, 2013

GalenEvil
Fix for vehicle parts not displaying properly
* Note: Will require tileset config files to be updated to the jsonized vehicle_part id values along with a "vp_" prefix to reduce potential conflicts later.
GalenEvil
fix for fix, actually works this time! I swear!
Does not allow for open or damaged tiles. That will need to be added in a separate PR as an addendum to the tileset definition format
@GalenEvil

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2013

Ready for merge if there are no issues found:

tiles_vpart_tweak_003
tiles_vpart_tweak_004

@Abalieno

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2013

...so?

@The13thRonin

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2013

Why is this not merged yet?

@atomicdryad atomicdryad merged commit 55ce1c7 into CleverRaven:master Oct 21, 2013

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.