Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let autotravel happen on other z-levels #35785

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@davidpwbrown
Copy link
Member

davidpwbrown commented Nov 30, 2019

Summary

SUMMARY: Bugfixes "Let autotravel happen on other z-levels"

Purpose of change

Fix autotravel not happening on other z-levels

Describe the solution

The path function added two tripoints together, but didnt account for the z coord, so it effectively doubled the z-coord when it wasnt 0, which made the path appear as a differnet z-level to players current position, so it bailed out.

Fixed this by manually amending the z-level of the combined tripoint afterwards.

Describe alternatives you've considered

N/A

Testing

Teleported to sewer, set autotravel route in overmap UI, it now works.

Additional context

N/A

@kevingranade

This comment has been minimized.

Copy link
Member

kevingranade commented Nov 30, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/cannot-confirm-overmap-autotravel/22102/6

@ZhilkinSerg ZhilkinSerg merged commit f23da5b into CleverRaven:master Nov 30, 2019
5 checks passed
5 checks passed
build
Details
JSON style check
Details
Validate PR
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.