Generalized hand vise, renamed angular grinder #36864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These had been unconsciously bugging me for a while now, good spot. two thumbs up here. |
|
Updating the IDs and migrating would be good for maintainability. IDs not matching names is irritating. |
ymber
added
<Bugfix>
ymber
reviewed
Jan 10, 2020
|
Alright, changes implemented. |
|
Who in the heck calls it an 'angular grinder'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Corrected regional names- vise and angle grinder"Purpose of change
Incorrect names were given for the hand vice and angular grinder (sic)
Describe the solution
Renamed angular grinder to angle grinder.
Changed Hand Vice to 'clamp', which more correctly described it. (We still don't have a real vise).
I left the ID's alone, no sense in changing those.
Describe alternatives you've considered
None.
Testing
String changes, none.
Additional context