update butchery to use requirements #42372
Conversation
KorGgenT
added
[C++]
|
There's a problem with pseudo-items: to the best of my knowledge the player has no way to search for furniture that has a pseudo-item providing a particular quality. That feels like a necessary step (but maybe it needn't come before this PR is merged). |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/butchering-in-0-e/24288/2 |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/butchering-in-0-e/24288/4 |
* Added overrides to the qualities introduced by CleverRaven/Cataclysm-DDA#42372 to fix quick butchery needing a surface, because that is an astoundingly tedious idea. * Also reduced surface demands for dissection so that low-level surfaces work for large creatures, and small creatures don't need any surface. * This also fixes dismembering them, I'm not even sure what absurdity in the code is tying dismemberment requirement to one of the other butchery requirements, but needing a clean fancy tarp to messily hack apart a body is a terrible idea. * Added an override to tarps, adding surface qaulity because CleverRaven/Cataclysm-DDA#42553 forgot them. * Cleaned out an obsolete item that hasn't been used since back when I was still a contributor. It was pinging the zero-weight and there was really no need to update it after literally 3-4 years of it being dummied out. * Zero-weight fixes for psuedo-items.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/dissecting-in-0-e/24327/7 |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/butchering-in-0-e/24288/33 |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/butchering-in-0-e/24288/35 |
Summary
SUMMARY: Features "update butchery to use requirements"Purpose of change
Moving data from hardcode into json, and also making the messaging clearer when tools are missing.
Describe the solution
use a
requirementfor various parts of butchery:field dress, quarter, skin, dismember:
field_dressdissect:
dissect_large,dissect_smallfull:
full_butchery_large,butchery_smallquick:
butchery_large,butchery_smallAdditionally, uses the same 6 tile range as crafting does.
Describe alternatives you've considered
Well we could keep butchery tools hardcoded i guess
Testing
spawned in various creates with and without tools.
Additional context
Inspired by 4c9000b