Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDelete current artifact ids before loading new ones to prevent repeated saving. #4281
Conversation
This comment has been minimized.
This comment has been minimized.
|
Apparently this doesn't fix the issue. |
freezerbunny
added some commits
Nov 11, 2013
This comment has been minimized.
This comment has been minimized.
|
That's it fixed. |
This comment has been minimized.
This comment has been minimized.
|
Artifacts were basically working on the assumption that all characters were in the same world and had the same artifacts. So yep, clearing on load seems sensible. Leaks the artifact itype, but ehh who cares. |
This comment has been minimized.
This comment has been minimized.
|
It shouldn't leak the artifact itype, because we're overwriting the ids anyway, so it'll just overwrite those itypes. |
This comment has been minimized.
This comment has been minimized.
|
it makes itypes with "new" and never uses "delete" |
GalenEvil
merged commit 23b92fd
into
CleverRaven:master
Nov 14, 2013
1 check passed
default
Merged build finished.
Details
freezerbunny
deleted the
freezerbunny:artifactsave-fix
branch
Dec 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
freezerbunny commentedNov 11, 2013
Fixes #4280