Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Logic for generic tile categories #4283
Conversation
added some commits
Nov 9, 2013
This comment has been minimized.
This comment has been minimized.
|
As explained here: #4236 But more specifically, at runtime or when you load a different tileset, you probably need to make a full index. So that when tiles are actually used it doesn't need to make any check, it just looks up the pre-made index. |
KA101
force-pushed the
CleverRaven:master
branch
from
a342a64
to
0da0595
Oct 30, 2014
This comment has been minimized.
This comment has been minimized.
|
This PR will probably not become mergeable. Closing. |
Coolthulhu
closed this
Apr 23, 2015
Coolthulhu
referenced this pull request
Apr 24, 2015
Closed
Close all those PRs that won't ever get merged #12105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GalenEvil commentedNov 11, 2013
I still need to test to see if it works as intended. How it works is checks in each drawing section to see if the tile exists, and if not it sets the id string to draw of the generic tile into the next step. Item drawing is messy with a long condition chain, so wondering if I should just make it a single generic item and not check to see what specific kind of item it is.
WIP due to needing to think about how to clean up a few things to make it work better, and setting up a test tileset/json combo to check usability and if there are any noticeable speed hits doing this.