Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Logic for generic tile categories #4283

Closed

Conversation

Projects
None yet
3 participants
@GalenEvil
Copy link
Contributor

commented Nov 11, 2013

I still need to test to see if it works as intended. How it works is checks in each drawing section to see if the tile exists, and if not it sets the id string to draw of the generic tile into the next step. Item drawing is messy with a long condition chain, so wondering if I should just make it a single generic item and not check to see what specific kind of item it is.

WIP due to needing to think about how to clean up a few things to make it work better, and setting up a test tileset/json combo to check usability and if there are any noticeable speed hits doing this.

@Abalieno

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2013

As explained here: #4236

But more specifically, at runtime or when you load a different tileset, you probably need to make a full index. So that when tiles are actually used it doesn't need to make any check, it just looks up the pre-made index.

@KA101 KA101 force-pushed the CleverRaven:master branch from a342a64 to 0da0595 Oct 30, 2014

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2015

This PR will probably not become mergeable. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.