Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFinish removing references to snares. #4285
Conversation
This comment has been minimized.
This comment has been minimized.
|
Yeah this is essential. |
fergus-dall
referenced this pull request
Nov 15, 2013
Closed
[0.9.RC1-194-g8f83223] Slime Pits displaying as Disectors in Labs #4353
This comment has been minimized.
This comment has been minimized.
|
Is there something holding this back from being merged? Everyone is seeing it and it's a relatively minor fix. I tried placing all traps and the only one that didn't seem to quite work was the tripwire, which I think I was just using wrong. |
This comment has been minimized.
This comment has been minimized.
|
More like Kevin was gone on a trip and I've been a bit busy. I'll take a look into merging it in a bit. |
Rivet-the-Zombie
added a commit
that referenced
this pull request
Nov 16, 2013
Rivet-the-Zombie
merged commit 20d5db0
into
CleverRaven:master
Nov 16, 2013
1 check passed
default
Merged build finished.
Details
ianestrachan
deleted the
ianestrachan:totally-remove-snares
branch
Nov 16, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianestrachan commentedNov 11, 2013
Fixes #4275 by removing all remaining references to snares; placing land mines now puts down land mines, and placing caltrops actually places caltrops, etc.