Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[for 0.9] Fix old save loading #4384
Conversation
kevingranade
added some commits
Nov 16, 2013
yobbobanana
merged commit c0d0e01
into
CleverRaven:0.9-branch
Nov 17, 2013
1 check failed
default
Merged build finished.
Details
This comment has been minimized.
This comment has been minimized.
|
i could not see any better way to do this at all. |
kevingranade
deleted the
kevingranade:fix-old-save-loading
branch
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedNov 16, 2013
This partially addresses loading some old saves, but I can't find a way to make it totally generic.
Some saves (https://drive.google.com/file/d/0B2KpFWC2n0CaZ3FUTkZOZi01Vm8/edit?usp=sharing) seems to have been generated with a save file version of 5, but wrote out as if it were version 4 format. If this happens, the user has to set the player.sav version to 4, then it should load.
If someone can find a better solution than this I'd be grateful.