Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds additional female clothing variety and "SKINTIGHT" flag. #4504
Conversation
freezerbunny
added some commits
Nov 19, 2013
This comment has been minimized.
This comment has been minimized.
|
Awesome! Only issue I can see here is adding underwear. The clothing layer system doesn't much approve of undergarments, and tends to levy big penalties for wearing many layers at once. |
Rivet-the-Zombie
reviewed
Nov 19, 2013
| "id" : "union_suit", | ||
| "name" : "union suit", | ||
| "weight" : 168, | ||
| "id" : "bra", |
This comment has been minimized.
This comment has been minimized.
Rivet-the-Zombie
Nov 19, 2013
Member
This ought to add a point or two of storage. IRL we tend to use it like an extra set of secure pockets. Classy, right?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks Rivet. I agree with your points. The main idea behind their inclusion (other than the RP factor) is that it will identify more zombies and bodies as female. Right now you rarely see a zombie that has a skirt, tights, or a dress, etc. This will improve gender equality! It'll also function as a way to add small units of warmth to bring you just above threshold where, should you put on something else, you may add too much warmth. |
This comment has been minimized.
This comment has been minimized.
|
Be sure to update the recipes as well -- tailoring can make long underwear bottoms and union suits, but with them as a different item, it may break some things. Don't forgot about the long underwear top, too. |
This comment has been minimized.
This comment has been minimized.
|
Long underwear is already implemented. The diff might just be displaying screwy things. |
This comment has been minimized.
This comment has been minimized.
|
Union suit and long underwear etc. weren't changed. As @AnderHammer says, the diff display is just showing it weird. |
Rivet-the-Zombie
reviewed
Nov 19, 2013
| @@ -1987,6 +2001,7 @@ | |||
| ["hoodie", 65], | |||
| ["under_armor", 20], | |||
| ["jersey", 40] | |||
| ["camisole", 60], | |||
This comment has been minimized.
This comment has been minimized.
Rivet-the-Zombie
Nov 19, 2013
Member
I haven't opened this up in N++ yet, but I think that this comma is unneeded.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Ah, okay -- better safe than sorry |
This comment has been minimized.
This comment has been minimized.
|
The rationale for not having underwear is twofold: I'm not saying not to add this, just that's the previous rationale. Also, you can see the "Merge with caution!" and "X Failed -- Merged build finished." messages, follow the details link to Jenkins, and click on "Command Line" to the upper left. This shows that the game compiled correctly, but failed to parse the json files. Please load your new files into the game to check for syntax errors before PRing it (or if you want feedback before it's ready, mark it [WIP]). |
freezerbunny
added some commits
Nov 19, 2013
This comment has been minimized.
This comment has been minimized.
|
@kevingranade Thanks. I agree with some of your points. I just find it a little strange that my character doesn't wear anything under her clothes, although I agree the inclusion of these objects could lead to strange behavior. As for the encumbrance system, that's been resolved by setting it to 0 coverage and 0 material thickness. It will still impart warmth, however. |
This comment has been minimized.
This comment has been minimized.
|
0 coverage/0 thickness doesn't make it unencumbering, the only way to do that is to make it not cover any bodyparts, which will also prevent warmth. Might be fixable with a tweak to the encumbrance code, might not. |
This comment has been minimized.
This comment has been minimized.
|
Ah yeah, retested and you're right. Adding a |
freezerbunny
added some commits
Nov 19, 2013
This comment has been minimized.
This comment has been minimized.
|
Male underwear added too, including the typical white vest worn under your regular clothes. |
This comment has been minimized.
This comment has been minimized.
All the packages at the store call those 'undershirts' not 'white vests' because a vest is a form of outerwear. |
This comment has been minimized.
This comment has been minimized.
|
Alrighty. My mother calls them vests you see. |
This comment has been minimized.
This comment has been minimized.
|
OK, here I thought the tank top & camo tank top were undershirts. Wev. |
freezerbunny
added some commits
Nov 22, 2013
This comment has been minimized.
This comment has been minimized.
|
Should be all done now. Enjoy.
|
freezerbunny
added some commits
Nov 23, 2013
This comment has been minimized.
This comment has been minimized.
|
Heh. Sometimes, github, your auto-linking is just silly. |
freezerbunny commentedNov 19, 2013
Update:
"SKINTIGHT"will negate layering penalty for wearing that object, but only if we aren't already wearing a skintight object on that body part. I have added the flag to everything that makes sense to have it.