Bullet Resistant Vest Re-Work #4645

EkarusRyndren · Nov 24, 2013

Rebalanced the generic vest and added several military grade vests plus spawning menus, craft/decraft, and new materials to go with the vests. (as well as added the "new" materials to their proper things.)

Assuming there are no complaints this is ready to go as is.

KA101 · Nov 24, 2013

How about "Suitable for wearing under clothing" or something? At minimum, "presidents" should be singular.

KA101 · Nov 24, 2013

This isn't gonna work (or at least not intuitively) as-is: once you have head encumbrance (such as a helmet), you can't wear any more things on your head.

You'd either have to equip the netting before the helmet (and either stash your gear between your head and the helm or manually adjust-clothing), not wear helmets, or make this a crafting ingredient for a line of craftable helmets-with-netting.

Works fine, just spawned a helmet and netting, put the helmet on first then the netting.

OK, good to know. Always gave me problems back when I was playing.

EkarusRyndren · Nov 25, 2013

Nothing is ever as simple as it seems... Gonna mark this as a WIP until I can figure out how to sort out the whole plate swapping without free-repairing the items involved...

Nemonole · Nov 25, 2013

Would this help the issue? Combined with changing "reversible" to false on the other recipes.

"result": "modularvest",
"category": "CC_ARMOR",
"skill_used": "tailor",
"difficulty": 0,
"time": 5000,
"reversible": false,
"autolearn": true,
"components": [
[
[ "modularvestsuper", 1 ],
[ "modularveststeel", 1 ],
[ "modularvestceramic", 1 ],
[ "modularvestkevlar", 1 ],
[ "modularvesthard", 1]
],
]

EkarusRyndren · Nov 25, 2013

@Nemonole It'd solve the problem of being able to fix them for nothing but you wouldn't be able to change the plates out and I'd like to keep this feature.

Nemonole · Nov 25, 2013

What do you mean not being able to change the plates out? I know the old plates sorta go 'poof' with my (sadly not optimal) suggestion... Do you mean being able to reuse the old plates to get a not in perfect condition vest? If so I fear that some serious coding shenanigans would be required...

EkarusRyndren · Nov 25, 2013

@Nemonole Sorry, I kinda glanced at what you posted at first. I see what you're getting at now. The "damaged" plates would have to be thrown away (or recycled?) in reality anyway so I'm not too concerned with them going "poof" and as far as getting a mint condition vest out of the deal is concerned that would be a little OP (the empty vest /does/ provide some protection) but I suppose it beats the alternative. I'll make the necessary changes if that's an acceptable compromise for the time being.

freezerbunny · Nov 25, 2013

freezerbunny reviewed Nov 25, 2013

View changes

freezerbunny · Nov 25, 2013

data/json/items/armor.json

@@ -2641,11 +2641,179 @@
        "warmth" : 15,
        "phase" : "solid",
        "enviromental_protection" : 0,
+        "encumbrance" : 1,
+        "bashing" : 6,
+        "flags" : ["VARSIZE", "STURDY"],


Add the "SKINTIGHT" flag if it's meant to be worn under clothing!

It's a rigid vest, it's not meant to be comfortable under the clothing... I don't think? Do we have anyone here who's ever worn one of the under-the-clothes vests? I've worn a military grade one but I'm pretty sure they're different.

"SKINTIGHT" doesn't denote comfort. It detracts from layers and not armor encumbrance, which won't have an effect unless you put additional clothes on.

Skintight is not appropriate for armor, even if worn under stuff. It's
literally intended for just very thin underclothes.

That's what I thought... I've yet to make any changes so it's no big deal XD

freezerbunny · Nov 25, 2013

freezerbunny reviewed Nov 25, 2013

View changes

freezerbunny · Nov 25, 2013

data/json/items/armor.json

+        "to_hit" : -3,
+        "storage" : 0,
+        "symbol" : "[",
+        "description" : "A high-tech, lightweight, flexible, bullet resistant vest. The ceramic disks used in it's construction make it impossible to repair, only replace.",


The ceramic disks used in it's (it is) construction

Change to: The ceramic disks used in ITS construction

There is no apostrophe to denote ownership with it. Its already indicates possession.

High-tech implies some mechanical or technological innovation (electronics). Possibly state-of-the-art instead.

freezerbunny · Nov 25, 2013

freezerbunny reviewed Nov 25, 2013

View changes

freezerbunny · Nov 25, 2013

data/json/items/armor.json

+        "to_hit" : -3,
+        "storage" : 4,
+        "symbol" : "[",
+        "description" : "A Modular Bullet Resistant Vest. It's armor pouches have Supper Alloy Plating in them giving it extra protection at some flexibility loss and additional weight.",


It's (it is) armor pouches have Supper Alloy Plating

Change to: ITS armor pouches have Supper Alloy Plating

There is no apostrophe to denote ownership with it. Its already indicates possession.

freezerbunny · Nov 25, 2013

I like the idea. Fix up some of the issues I raised and possible adjust the spawn-rates (be less generous) and it should be good. The regular kevlar vest should still be the defacto. The additional stuff needs to be rare.

EkarusRyndren · Nov 26, 2013

@freezerbunny The default vests are meant to be something more along the lines of this http://www.controlelectronic.com/Bullet%20proof%20VestPhoto.jpg at least in the re-work. While the modular vests are meant to be more along the lines of this http://upload.wikimedia.org/wikipedia/commons/thumb/4/49/Modular_Tactical_Vest_components.jpg/800px-Modular_Tactical_Vest_components.jpg

But I will tone the spawns down a bit regardless.

freezerbunny · Nov 26, 2013

Remember to fix the item descriptions.

swwu · Nov 26, 2013

@EkarusRyndren On the topic of item descriptions I'm assuming "Supper Alloy" should probably be "Superalloy"? Unless we're referring to a combination of metals useful in preparing meals :D

Also FWIW everything else referring to "superalloy" has it as one word rather than two (see: "superalloy plating", "superalloy sheet").

Rivet-the-Zombie · Dec 3, 2013

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie · Dec 3, 2013

data/json/items/melee.json

+    "id": "ceramic_armor",
+    "symbol": ",",
+    "color": "yellow",
+    "name": "ceramic plate",


Can we have a slightly different name here?

That or change the extant ceramic plate (which is dinnerware) to have a different name.

Rivet-the-Zombie · Dec 3, 2013

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie · Dec 3, 2013

data/json/items/armor.json

+        "bashing" : 6,
+        "flags" : ["VARSIZE", "STURDY"],
+        "coverage" : 85,
+        "material_thickness" : 6


I'd like to suggest a change here?

The base model of this vest has
Bash: 96 Cut: 192
Which seems really high. Like, 'I can play catch with a mininuke' sort of high.
It might be worth it to reduce the material_thickness a bit. It won't compromise the armor in any fashion to do so, it will just reduce the numbers down to something a bit more sane.

On the other hand, changing the hardsteel material's stats might be a better solution.

Rivet-the-Zombie · Dec 3, 2013

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie · Dec 3, 2013

data/json/items/armor.json

+        "enviromental_protection" : 0,
+        "encumbrance" : 0,
+        "bashing" : 0,
+        "flags" : ["SKINTIGHT"],


This probably isn't the right tag for this. I'm not entirely sure what would be, but I don't think it's this one.

dwarfkoala · Dec 3, 2013

Hey, nerfed Hard plating for vehicles? Why would you do that?

EkarusRyndren · Dec 3, 2013

@dwarfkoala No, in fact hard plating for vehicles if it feeds from the materials file should be /stronger/ overall now. I added several new materials (hard plating being one of them)

dwarfkoala · Dec 3, 2013

Oooh. Ok. I was kinda mystified how a crazy vehicle builder like myself
would "nerf the hell out of" hard plating, considering how wafer thin steel
plating is.

On Mon, Dec 2, 2013 at 5:08 PM, Ekarus Ryndren notifications@github.comwrote:

@dwarfkoala https://github.com/dwarfkoala No, in fact hard plating for
vehicles if it feeds from the materials file should be /stronger/ overall
now. I added several new materials (hard plating being one of them)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4645#issuecomment-29674853
.

Tweaks the Kevlar.
Nerfed the generic vest and added several military grade vests plus spawning menus, craft/decraft, and new materials to go with the vests. (as well as added the "new" materials to their proper things.)

Loading status checks…

e2e6f7e

Wording fix.

Loading status checks…

888e0af

Spelling, Grammar, and Spawn Chance Fixes

Loading status checks…

529fa80

Nerfed the hell out of the Hard Plating
Also fixed a spelling error, made the difference between a dinner plate and an armor plate more obvious, rebalanced the other MBR Vests, rebalanced PA, and removed the SKINTIGHT flag from the helmet netting.

Loading status checks…

cc7b493

Rivet-the-Zombie added a commit that referenced this pull request Dec 3, 2013

Merge pull request #4645 from EkarusRyndren/MoreMilArmor
Bullet Resistant Vest Re-Work

ec79385

Rivet-the-Zombie merged commit ec79385 into CleverRaven:master Dec 3, 2013
1 check passed

1 check passed

default
Details

EkarusRyndren deleted the EkarusRyndren:MoreMilArmor branch Dec 3, 2013

CleverRaven/Cataclysm-DDA

Join GitHub today

Bullet Resistant Vest Re-Work #4645

Conversation

EkarusRyndren commented Nov 24, 2013

This comment has been minimized.

KA101 commented on data/json/items/armor.json in e2e6f7e Nov 24, 2013

This comment has been minimized.

KA101 commented on data/json/items/armor.json in e2e6f7e Nov 24, 2013

This comment has been minimized.

EkarusRyndren replied Nov 24, 2013

This comment has been minimized.

KA101 replied Nov 25, 2013

This comment has been minimized.

EkarusRyndren commented Nov 25, 2013

This comment has been minimized.

Nemonole commented Nov 25, 2013

This comment has been minimized.

EkarusRyndren commented Nov 25, 2013

This comment has been minimized.

Nemonole commented Nov 25, 2013

This comment has been minimized.

EkarusRyndren commented Nov 25, 2013

freezerbunny reviewed Nov 25, 2013 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

freezerbunny reviewed Nov 25, 2013 View changes

This comment has been minimized.

freezerbunny reviewed Nov 25, 2013 View changes

This comment has been minimized.

This comment has been minimized.

freezerbunny commented Nov 25, 2013

This comment has been minimized.

EkarusRyndren commented Nov 26, 2013

This comment has been minimized.

freezerbunny commented Nov 26, 2013

This comment has been minimized.

swwu commented Nov 26, 2013

Rivet-the-Zombie reviewed Dec 3, 2013 View changes

This comment has been minimized.

Rivet-the-Zombie reviewed Dec 3, 2013 View changes

This comment has been minimized.

Rivet-the-Zombie reviewed Dec 3, 2013 View changes

This comment has been minimized.

Rivet-the-Zombie added a commit that referenced this pull request Dec 3, 2013

Hide details View details Rivet-the-Zombie merged commit ec79385 into CleverRaven:master Dec 3, 2013 1 check passed

1 check passed

EkarusRyndren deleted the EkarusRyndren:MoreMilArmor branch Dec 3, 2013

This comment has been minimized.

dwarfkoala commented Dec 3, 2013

This comment has been minimized.

EkarusRyndren commented Dec 3, 2013

This comment has been minimized.

dwarfkoala commented Dec 3, 2013

KA101 commented on `data/json/items/armor.json` in `e2e6f7e` Nov 24, 2013

KA101 commented on `data/json/items/armor.json` in `e2e6f7e` Nov 24, 2013

freezerbunny reviewed Nov 25, 2013

View changes

freezerbunny reviewed Nov 25, 2013

View changes

freezerbunny reviewed Nov 25, 2013

View changes

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie reviewed Dec 3, 2013

View changes

Rivet-the-Zombie merged commit `ec79385` into CleverRaven:master Dec 3, 2013
1 check passed