Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds item spawn density scaler option for worldgen. #4694
Conversation
This comment has been minimized.
This comment has been minimized.
dwarfkoala
commented
Nov 26, 2013
|
That's remarkably simple, actually. Can't wait to test it! |
This comment has been minimized.
This comment has been minimized.
vache
commented on src/mapgen.cpp in 8ac533c
Nov 26, 2013
|
Any option spawn rate > 1.0 will result in HUGE amounts of items being spawned. A 1.5 item spawn will turn anything with chance ~67 and up to a near 100% chance to spawn and throw tons of items out. |
This comment has been minimized.
This comment has been minimized.
|
A max of 1.0 and min of 0.1 with default to 0.5 should be sufficient, given that too much stuff drops already. Or we could default it to 1.0 so as to not make the "default game" harder. Regardless I'm sure someone will come in and say "This is just a work-around to the fundamental problem with how items spawn." and will want a rewrite of the entire item drop system. |
This comment has been minimized.
This comment has been minimized.
|
@freezerbunny I'd disagree with that "given". 1.0 is fine. Turning it up might be amusing. ;-) |
Rivet-the-Zombie
added some commits
Nov 26, 2013
freezerbunny
reviewed
Nov 26, 2013
|
|
||
| int lets_spawn = 100 * OPTIONS["ITEM_SPAWNRATE"]; | ||
|
|
||
| if(rng(1,100 > lets_spawn)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
C'mon Jenkins don't fail me now! |
This comment has been minimized.
This comment has been minimized.
A global option to adjust item spawns seems like it's a good basis for controlling spawn rates regardless of how it ends up being implemented. |
This comment has been minimized.
This comment has been minimized.
|
@Rivet-the-Zombie Wait until someone says that to field your response! Anyway looks good to go, if it works |
This comment has been minimized.
This comment has been minimized.
dwarfkoala
commented
Nov 26, 2013
|
Grarrr herr this is bad and awful blargh hurr |
This comment has been minimized.
This comment has been minimized.
|
Looks good in testing. Merge this suckah plz. |
This comment has been minimized.
This comment has been minimized.
moist-zombie
commented
Nov 27, 2013
|
Amazing idea :D |
This comment has been minimized.
This comment has been minimized.
|
Worked even better in testing. |
This comment has been minimized.
This comment has been minimized.
dwarfkoala
commented
Nov 28, 2013
|
Ready to merge, i'd say! On Wed, Nov 27, 2013 at 4:11 PM, KA101 notifications@github.com wrote:
|
Rivet-the-Zombie commentedNov 25, 2013
With LOTS and LOTS and LOTS of awesome help from @freezerbunny & @BrianLefler!