Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds item spawn density scaler option for worldgen. #4694

Merged
merged 6 commits into from Nov 28, 2013

Conversation

Projects
None yet
7 participants
@Rivet-the-Zombie
Copy link
Member

commented Nov 25, 2013

With LOTS and LOTS and LOTS of awesome help from @freezerbunny & @BrianLefler!

@dwarfkoala dwarfkoala referenced this pull request Nov 25, 2013

Closed

Loot scaling factor #4693

@dwarfkoala

This comment has been minimized.

Copy link

commented Nov 26, 2013

That's remarkably simple, actually. Can't wait to test it!

@vache

This comment has been minimized.

Copy link

commented on src/mapgen.cpp in 8ac533c Nov 26, 2013

Any option spawn rate > 1.0 will result in HUGE amounts of items being spawned. A 1.5 item spawn will turn anything with chance ~67 and up to a near 100% chance to spawn and throw tons of items out.

@freezerbunny

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2013

A max of 1.0 and min of 0.1 with default to 0.5 should be sufficient, given that too much stuff drops already.

Or we could default it to 1.0 so as to not make the "default game" harder.

Regardless I'm sure someone will come in and say "This is just a work-around to the fundamental problem with how items spawn." and will want a rewrite of the entire item drop system.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2013

@freezerbunny I'd disagree with that "given". 1.0 is fine. Turning it up might be amusing. ;-)

Rivet-the-Zombie added some commits Nov 26, 2013


int lets_spawn = 100 * OPTIONS["ITEM_SPAWNRATE"];

if(rng(1,100 > lets_spawn))

This comment has been minimized.

Copy link
@freezerbunny

freezerbunny Nov 26, 2013

Contributor

Change to if(rng(1,100) > lets_spawn) and we're good to go.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2013

C'mon Jenkins don't fail me now!

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2013

Regardless I'm sure someone will come in and say "This is just a work-around to the fundamental problem with how items spawn." and will want a rewrite of the entire item drop system.

A global option to adjust item spawns seems like it's a good basis for controlling spawn rates regardless of how it ends up being implemented.

@freezerbunny

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2013

@Rivet-the-Zombie Wait until someone says that to field your response! 💨

Anyway looks good to go, if it works 👍

@dwarfkoala

This comment has been minimized.

Copy link

commented Nov 26, 2013

Grarrr herr this is bad and awful blargh hurr
global option is sux go for total revamp grughhh

@KA101

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

Looks good in testing. Merge this suckah plz.

@moist-zombie

This comment has been minimized.

Copy link

commented Nov 27, 2013

Amazing idea :D

@KA101

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2013

Worked even better in testing.

@dwarfkoala

This comment has been minimized.

Copy link

commented Nov 28, 2013

Ready to merge, i'd say!

On Wed, Nov 27, 2013 at 4:11 PM, KA101 notifications@github.com wrote:

Worked even better in testing.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4694#issuecomment-29430762
.

@kevingranade kevingranade merged commit 2170660 into CleverRaven:master Nov 28, 2013

1 check passed

default Merged build finished.
Details

@Rivet-the-Zombie Rivet-the-Zombie deleted the Rivet-the-Zombie:Loot-scaler branch Nov 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.