Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes grammar and description. #4789
Conversation
This comment has been minimized.
This comment has been minimized.
|
No real substantive comments from me but this PR is pure gold. |
This comment has been minimized.
This comment has been minimized.
|
XD Wasn't sure about that one... Nice. |
freezerbunny
reviewed
Dec 2, 2013
| @@ -1936,7 +1936,7 @@ | |||
| "symbol": "(", | |||
| "color": "dark_gray", | |||
| "name": "RM802 grenade launcher", | |||
| "description": "The Rivtech RM802 pump-action 40mm grenade launcher is designed to be a step ahead of single-shot grenade launchers by allowing sustained heavy firepower. However, its capacity is limited must be used with careful planning.", | |||
| "description": "The Rivtech RM802 pump-action 40mm grenade launcher was designed to be a step ahead of single-shot grenade launchers by allowing sustained heavy firepower. However, its capacity is still fairly limited so it must be used with careful planning.", | |||
This comment has been minimized.
This comment has been minimized.
freezerbunny
Dec 2, 2013
Contributor
However, its capacity is still fairly limited
to
However, its capacity is fairly limited???
Gotta minimize dem words!
This comment has been minimized.
This comment has been minimized.
KA101
Dec 2, 2013
Contributor
In game-messages, maybe--Wuzzy makes a valid point about size diffs in translation. But in item descriptions, where you have pretty much a whole window?
This comment has been minimized.
This comment has been minimized.
freezerbunny
Dec 2, 2013
Contributor
If a word contributes minimal extra information or nothing at all to a sentence, then it doesn't need to be used.
The above with that principle once more:
If a word contributes little to a sentence then it doesn't need to be used.
It's all about effective style which, in the long run, reads a lot better and will lend the game that polished feel. It is nitpicking, but I think it's so easy to change that it should be pointed out.
freezerbunny
added a commit
that referenced
this pull request
Dec 3, 2013
Rivet-the-Zombie commentedDec 1, 2013
No description provided.