Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage Flake8 E265 #48284

Merged
merged 2 commits into from Mar 31, 2021
Merged

Triage Flake8 E265 #48284

merged 2 commits into from Mar 31, 2021

Conversation

jbytheway
Copy link
Contributor

Summary

None

Purpose of change

To complete the triage of Flake8 errors & warnings.

E265 forces a space after the # on comments.

But lacking a space is used to indicate commented-out code, rather than genuine comments, and our code has commented-out print calls that seem potentially useful to keep.

Describe the solution

Decide not to enable Flake8 E265 because it prevents us keeping commented-out debug print messages.

Describe alternatives you've considered

Delete the debug print calls.

Testing

Ran flake8.

Additional context

This branch slipped through the cracks when I was working through all the flake8 triage a while back. Rediscovered it while sorting through my old branches.

Decide not to enable Flake8 E265 because it prevents us keeping
commented-out debug print messages.
.flake8 Outdated Show resolved Hide resolved
@BrettDong BrettDong added the Code: Tooling Tooling that is not part of the main game but is part of the repo. label Mar 31, 2021
@ZhilkinSerg ZhilkinSerg added the [Python] Code made in Python label Mar 31, 2021
Co-authored-by: Binrui Dong <brett.browning.dong@gmail.com>
@ZhilkinSerg ZhilkinSerg merged commit 23c1bf9 into CleverRaven:master Mar 31, 2021
@jbytheway jbytheway deleted the flake8_E265_E501 branch March 31, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tooling Tooling that is not part of the main game but is part of the repo. [Python] Code made in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants