Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMake shock damage make sense. #4856
Conversation
This comment has been minimized.
This comment has been minimized.
|
So all those bumpers people add now mean something. Nice job. |
kevingranade
merged commit 5f6ea0c
into
CleverRaven:master
Dec 4, 2013
ianestrachan
deleted the
ianestrachan:sensible-shock-damage
branch
Dec 4, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianestrachan commentedDec 4, 2013
Fixes #3053 and adjusts the whole "shock damage" system in general.
I already changed it in a previous PR so that shock damage would only damage frames (since it's essentially vibration, which the frame would absorb the brunt of, not stuff screwed/welded/duct-taped onto the frame). It's also kind of absurd that running over a zombie makes your seatbelt explode.
Well, no longer!
Shock damage is halved with every square from the collision point, and never applies to the collision point itself (since it already took collision damage).
In essence, you'll have to repair the front of the car more often and the back of the car almost never (unless you actually reverse into something or have zombies whack the back of your car). This also means you can be more economical with your armor, since armor protects from collision damage but not shock damage - armor up the front of your car and you'll be good to go.
(You also won't have gas tanks 20 tiles away explode when your 3-block-long vehicle bumps a spitter zombie, @EkarusRyndren.)
Example: You hit a Jabberwock in a semi doing 140km/h for 600 damage.