Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix update pot #5078
Conversation
VlasovVitaly
added some commits
Dec 15, 2013
This comment has been minimized.
This comment has been minimized.
|
I have not 100% sure about this. May be somebody with knowledge of JSON parser can review this. But game works on linux. Translated strings works too. |
yobbobanana
merged commit fbd6c16
into
CleverRaven:master
Dec 20, 2013
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
|
I tested that item_groups change both with python's json module (which is quite strict) and with "make json-check" (if that works the game will run with it anyway), and it looks fine. Guess those brackets were extraneous. |
VlasovVitaly
deleted the
VlasovVitaly:fix-update-pot
branch
Dec 23, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
VlasovVitaly commentedDec 15, 2013
Fixing update-pot script. again.
Then running it. Works.