Fix negative skill xp and add debugging #50929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix negative skill xp"
Purpose of change
Fixes #50921, negative skill xp prevents skill gain
Describe the solution
For players affected by the bug, reset the xp to 0 on load so they can continue training their skill.
Add checks in
train()
to prevent_exercise
from going negative and print debugging info if it would have.Describe alternatives you've considered
Testing
Additional context