Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up(Ready) Region settings (playable wip) + jsonized shop lists + jsonized grass_or_dirt (biomes wip) + dynamic option values #5134
Conversation
atomicdryad
added some commits
Dec 16, 2013
This comment has been minimized.
This comment has been minimized.
|
Oh wow so much wow. Can't wait. |
This comment has been minimized.
This comment has been minimized.
|
I like everything about this. |
This comment has been minimized.
This comment has been minimized.
dwarfkoala
commented
Dec 20, 2013
|
You are a saint, you know that? |
This comment has been minimized.
This comment has been minimized.
duskgao
commented
Dec 20, 2013
|
awesome!! |
This comment has been minimized.
This comment has been minimized.
|
Looks awesome overall, but all the shelters are being generated overrun with cacti? |
kevingranade
reviewed
Dec 23, 2013
| std::vector<std::pair<std::string, std::string> > vPages; | ||
| std::map<int, std::vector<std::string> > mPageItems; | ||
| std::map<std::string, std::string> optionNames; | ||
| int iWorldOptPage; | ||
|
|
||
| options_data::options_data() { |
This comment has been minimized.
This comment has been minimized.
kevingranade
Dec 23, 2013
Member
Does this have anything to do with the PR as a whole? If it's disabled it seems like it doesn't.
If it's unrelated please PR seperately.
This comment has been minimized.
This comment has been minimized.
dwarfkoala
commented
Dec 23, 2013
|
Shelters being overrun with... Cacti? Cacti? This sounds really exciting. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
Sorry I was unclear, the terrain in and around the shelter was all being set to cactus. |
This comment has been minimized.
This comment has been minimized.
|
Found the issue, fixed in #5212 |
This comment has been minimized.
This comment has been minimized.
|
Cool, I'll take a look at merging this and the fix asap, because it looked |
atomicdryad commentedDec 19, 2013
This is part of a larger overmap overhaul with the eventual goal of an overmap of overmaps (regionmap), and the introduction of coastlines, biomes, watersheds, and various spatial traits for demographics (human, criitter, and other).. I've forced myself to stop and pr before going on a fix_roads_and_by_roads_i_mean_sewers tangent, and think it best this is done in stages anyway. This pr adds:
The TODO is a mile long, however this pr is fully operational and should add variety to the game, if manually (vs geographically)
Suggestions/thoughts?