Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item description now states if an item of food will spoil of not. #5161

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@desrik
Copy link
Contributor

commented Dec 21, 2013

Does not tell the player how long before it spoils, just a simple "This food [will/will not] spoil."

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2013

You beat me to it: #5162

You haven't handled already-rotten food, however. Or saprovore characters.

@desrik

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2013

@ianestrachan There is arlready a mechanism in place to let the player know that food is rotten. As for sapravore trait, this mechinism has nothing to do with eating the food. This only shows if a food is perishable or not. I fail to see how alerting the player of goes_bad() results has anything to do with eating it.

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2013

While that is true, it seems a little odd to say "this food will spoil" when it has already spoiled.

@desrik

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2013

Ah yes, I see what you mean.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 27, 2013

I'm going with the other PR, it's a little shorter and has more specific messages, thanks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.