Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMention if food will rot in the description #5162
Conversation
ianestrachan
added some commits
Dec 21, 2013
ianestrachan
referenced this pull request
Dec 21, 2013
Closed
Item description now states if an item of food will spoil of not. #5161
KA101
reviewed
Dec 21, 2013
src/item.cpp
Outdated
| dump->push_back(iteminfo("DESCRIPTION", "\n\n")); | ||
| if(rotten()) { | ||
| if(g->u.has_trait("SAPROVORE")) { | ||
| dump->push_back(iteminfo("DESCRIPTION", _("This food has started to rot, but that just adds to the flavor."))); |
This comment has been minimized.
This comment has been minimized.
KA101
Dec 21, 2013
Contributor
FWIW saprovores and Expanded Digestive Tract-havers don't get any better morale out of eating rotten food: ick, it still doesn't taste so good. Something along the lines of "but you've had worse" might be better?
KA101
reviewed
Dec 21, 2013
src/item.cpp
Outdated
| { | ||
| dump->push_back(iteminfo("DESCRIPTION", "\n\n")); | ||
| if(rotten()) { | ||
| if(g->u.has_trait("SAPROVORE")) { |
This comment has been minimized.
This comment has been minimized.
KA101
Dec 21, 2013
Contributor
Expanded Digestive Tract ("bio_digestion") gives a 66% chance to avoid food poisoning, and bypasses the health penalty, but doesn't bypass the sniff test (it still smells awful, Y/N before eating). Worth a line?
This comment has been minimized.
This comment has been minimized.
kevingranade
merged commit 6f0240d
into
CleverRaven:master
Dec 27, 2013
1 check failed
default
Unmergeable pull request.
ianestrachan
deleted the
ianestrachan:food-rot-mention
branch
Dec 27, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianestrachan commentedDec 21, 2013
As requested in: http://smf.cataclysmdda.com/index.php?topic=4849.0
If an item is perishable (or it's a food container with perishable food), the description will state that the item will eventually rot.
Also handles already-rotten food (and saprovores).