Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helipad.json: Use barbed wire fence #52224

Merged
merged 1 commit into from Oct 11, 2021

Conversation

NetSysFire
Copy link
Member

Summary

Balance "Replace chain link fence with barbed wire fence"

Purpose of change

This is a secured military building. It should use barbed wire fence instead of a regular chainlink fence.

Describe the solution

Just replaces a single entry in the palette.

Describe alternatives you've considered

I don't know really. I considered to just leave it be because it has turrets, why would it also need barbed wire but this is the military and there is the Cataclysm going on. Defence in depth is a thing after all.

Testing

Applied the change locally. Travelled until I found a helipad. All chainlink fence has been correctly replaced by its barbed wire equivalent.

Additional context

n/a

@Maleclypse
Copy link
Member

Wouldn’t you have the barbed wire outside of the chainring fence for two layers of defense.

@Maleclypse Maleclypse added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Oct 10, 2021
@NetSysFire
Copy link
Member Author

Probably, but we do not have this anywhere else yet. The refugee center has two layers of barbed wire but this is about it. So I think this is sufficient for now.

@NetSysFire
Copy link
Member Author

So I just looked at the fence types with other tilesets and it looks like a barbed wire fence is just barbed wire between posts, not just an upgraded chainlink fence with barbed wire on top. imho this should be a separate object but it might be non-trivial to implement since it blocks climbing in some cases and is much higher than these small fence posts.

So yes, putting barbed wire on the ground in front of a chainlink fence with barbed wire on top makes more sense if this gets implemented.

@Shodan14
Copy link

Might be good to have a stronger razor wire fence for official stuff to differentiate it from the flimsy farmyard stuff.

@NetSysFire
Copy link
Member Author

I agree, but this is out of scope for this PR. There have been some discussions in the IRC and forums about this and it really does make sense to add this for many buildings.

@ZhilkinSerg ZhilkinSerg merged commit 79ab698 into CleverRaven:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants