Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready] Mutcat thresholds #5235

Merged
merged 9 commits into from Jan 3, 2014

Conversation

Projects
None yet
4 participants
@KA101
Copy link
Contributor

commented Dec 28, 2013

Starting with enforcing Purifiability on the IV purifier, and the prereq slots are now working as intended.

Boolean is in. Couple days later, so is the trait-gain and the traits.

It all works, and the infrastructure is fully operational. Thanks to vede on the IRC, it's even streamlined a bit. (Much appreciated.) Follow-up PRs will be along shortly to fill it out and add a special-effects budget.

Equation converted and aggravating brace-glitch fixed. Unfortunately, it's gonna need a manual merge now, apparently, so we may be waiting longer..

KA101 added some commits Dec 28, 2013

No injecting past non-purifiability
No loophole for you!
Under Construction
FWIW the category-mutagens don't seem to be accepting the dual-prereqs
as easily as the standard ones.  Looking into the matter.
Good to go
Includes some syntax fixes too.  Now to actually get the Threshold
effects together (they'll be one-offs in the iuse, I think.)
Safety-catch
I'll handle the threshold-gaining in a separate PR--it'll likely show up
in the iuse, be a roll that gets easier based on your category strength.
@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 31, 2013

The code looks sound, it does need some actual traits that use the threshold and 2nd prerequisite list for merge.

KA101 added some commits Dec 31, 2013

Remove testbed remnant
"MAYBE" was the test trait for prereqs2.  You needed (("CLAWS" ||
"CLAWS_RETRACT") && "PREREQ") to get "MAYBE".

The Threshold trait was UHUH and the test-trait that required it was
NOPE, incidentally.  Dev trivia FTW.
Thresholds and initial post-Thresh mutations
There will be more post-thresh and double-prereqs.  But these ought to
start things off well.
WIP
Committing to change-branch.  The changes to mutation.cpp are useful,
the rest not yet so much.
Fully operational
Now, the special-effects team hasn't gone over it, but I think that can
wait for the next PR.

Compiled and playtested.  Everything works.

Merge when ready, please.
@dwarfkoala

This comment has been minimized.

Copy link

commented Jan 3, 2014

Hrm, let me see if I understand this.

If you mutate enough along a line, you can get non-purifiable traits that indicate you've gone beyond the point of no return, which allows you to gain the more intense mutations along those chains. A threshold will only occur when you've surpassed a certain point in a single mutation line, and once you've thresholded, you cannot gain a second threshold.

Some questions to ask:
Can you gain traits that do not require a threshold when you've gone beyond a threshold?

If you mutate, will your post-threshold traits ever be canceled out by that mutation?

Are post-threshold traits purifiable? Even if you can't go back to humanity, can you at least go back to not-completely-a-bear?

@KA101

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2014

Thresholds require you to have a certain amount of "category strength", and become more likely as your strength in the category increases. (Quickest way to estimate category strength is to check the character's dreams. If they're frequent and specific, you're likely eligible.) One threshold per character, and no, they're not purifiable.

Yes, you continue to gain traits that didn't need a threshold as you normally would, for now at least. I'm thinking one effect of thresholds will be to make category-enforcement much harsher.

Traits that require a Threshold as a prerequisite can be affected like any other trait. Non-purifiability is a separate boolean. You could set Rough Skin to non-purifiable if you wanted. Don't know why you'd do that, but you could.

Likewise, requiring a Threshold doesn't require non-purifiability. Some traits may be permanent. Others, not.

(And there's nothing that prevents one trait from removing a non-purifiable trait. The system's pretty tinkerable.)

Bracket glitch & proportionality
Alpha still doesn't have enough to breach easily but turned out the
code-combining was causing problems.  Fixed now, and proportionality is
probably a better approach.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 9e4177a into CleverRaven:master Jan 3, 2014

1 check failed

default Unmergeable pull request.

@KA101 KA101 deleted the KA101:MutThresh-continued branch Jan 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.