Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExtra Light Frames, Boards, Roofs, and Boxes #5554
Conversation
KA101
reviewed
Jan 16, 2014
data/json/items/vehicle_parts.json
Outdated
| @@ -24,6 +41,23 @@ | |||
| }, | |||
| { | |||
| "type":"GENERIC", | |||
| "id" : "basket", | |||
| "name" : "wire basket", | |||
| "description" : "A large wire basket from a shopping cart", | |||
This comment has been minimized.
This comment has been minimized.
KA101
Jan 16, 2014
Contributor
Missing period. Apart from that, was mildly confused when I didn't see basketsm. Might be worth breaking out that bike baskets are the same stuff as chain-link fencing so folks think to grab some.
This comment has been minimized.
This comment has been minimized.
|
Looks awesome, nice going as always. |
This comment has been minimized.
This comment has been minimized.
|
Why hasn't this been landed yet? Is there a content freeze right now? |
This comment has been minimized.
This comment has been minimized.
|
No, it just wasn't finished the last time I looked at it, and github didn't ping me when that 2nd commit was added. |
kevingranade
merged commit 293be6f
into
CleverRaven:master
Jan 20, 2014
EkarusRyndren
deleted the
EkarusRyndren:XLFrames-and-parts
branch
Jan 30, 2014
kevingranade
changed the title
Extra Light Frames, Boards, Roofs, and Boxes [Ready]
Extra Light Frames, Boards, Roofs, and Boxes
Sep 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
EkarusRyndren commentedJan 16, 2014
Extra Light Frames!
Think pipework frames. They're lighter and less durable than wooden frames.
Extra Light Boards!
Okay a pipe to gap that space and make it harder for the zeds to grab you.
Extra Light Roofs!
A bit of cloth over your head will hopefully keep that acid rain out...
Shopping Cart Baskets and Bicycle Baskets!
Because having a trunk for a Shopping cart seemed a bit much. Shopping Cart baskets hold more and weigh more while Bicycle baskets are the opposite.
Nerfed pedals
To reflect lighter weight materials on the bike.
Recipes for shopping car baskets , XL Frames, and vehicle listings for the new parts.