New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made mod that can be loaded through the mod manager. #5848

Merged

KA101 merged 5 commits into CleverRaven:master from redice99:ew_mod

Feb 2, 2014

Contributor

redice99 commented Jan 31, 2014

I had to remove the crafting recipes for the modified
full auto CW-24s, because the mod manager had some problems
with them.

Added the CW-24K, which fires the 7,62x39mm.
Tested, everything works ok.


      Made mod that can be loaded through the mod manager.

I had to remove the crafting recipes for the modified
full auto CW-24s, because the mod manager had some problems
with them.

Added the CW-24K, which fires the 7,62x39mm.
Tested, everything works ok.

67cb40c

Contributor

macrosblackd commented Jan 31, 2014

Awesome! Glad to see people using the mod manager.

Contributor

macrosblackd commented Jan 31, 2014

One thing though, you may want to go through an format the spacing so that there aren't any tabs

Contributor

BevapDin commented Jan 31, 2014

because the mod manager had some problems with them.

What type of problems? Recipes should work fine with the mod manager.

Contributor Author

redice99 commented Jan 31, 2014

macrosblackd:
I don't know why github shoves those lines all around. I have a nice spacing in sublime text.

BevapDin: I will check it and report it back.
Edit: Dang, my bad, forgot to include the modified full auto weapons in the ew_weapons.json. Sorry to blame the mod loader. :)
I can push the fixed files even if I made a pull request before, yes?

Contributor

Zireael07 commented Jan 31, 2014

Yes, you can, the pull request will be automatically updated.

Contributor

macrosblackd commented Jan 31, 2014

Github does it because in some areas you are using tabs and others are using spaces.


      Fixed the files in the mod.

Should work without problems now.

a79baa4

Contributor Author

redice99 commented Jan 31, 2014

Well, good to know. Is there any fast way to format the spacing?

Contributor

macrosblackd commented Jan 31, 2014

a quick search turned up this plugin for sublime
https://github.com/dzhibas/SublimePrettyJson


      Fixed spacing.

ad3dd1b

Contributor Author

redice99 commented Jan 31, 2014

Thanks macrosblackd. Fixed the spacing.

Contributor

KA101 commented Jan 31, 2014

I'll get to this after the backlog. Thanks.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_ammo.json Outdated

  
                "name" : "6.54x42mm 9N8",

                "symbol" : "=",

                "color" : "dark_gray",

                "description" : "Inspired by the unsuccessful XM-32 rifle, which used the improved .270 round, Alexander Sarafanov developed the 6.54x42mm rifle cartrige for his new SVS-24 Assault Rifle. The perfect mix of accuracy, stopping power and reliability. At least, so they say.",

KA101 Jan 31, 2014

Contributor

Little wordy there; can probably lose the "best" and "so they say" verbiage.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_ammo.json Outdated

  
                "name" : "6.54x42mm 9N12",

                "symbol" : "=",

                "color" : "dark_gray",

                "description" : "The 6.54x42mm 9N12 was designed to defeat advanced ballistic armor, like MBR vests and early power armor thanks to its tungsten carbide core. Kinetic energy penetrators based on tungsten or depleted uranium were used successfully in armored vehicles in the late 20th and the 21th century.",

KA101 Jan 31, 2014

Contributor

Same problem. Good ammo will prove itself, and this can be condensed to "the $AMMO's tungsten core, designed to defeat ballistic armor, follows the use of high-density penetrators in late 20th-century armored fighting vehicles" or something like that.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_ammo.json Outdated

  
                "name" : "5.45x39mm 5N7",

                "symbol" : "=",

                "color" : "yellow",

                "description" : "The 5.45x39mm was the standard ammunition for the AK series from 1974. It's designers were inspired by the .223 cartridge.",

KA101 Jan 31, 2014

Contributor

No apostrophe when its is the plural. It's = it is.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_ammo.json Outdated

  
                "name" : "5.45x39 7N22",

                "symbol" : "=",

                "color" : "yellow",

                "description" : "This is the armor-piercing cartridge with a steel penetrator, which was introduced in 1998. There is a tungsten carbide variant too, it is unavailable in the US though.",

KA101 Jan 31, 2014

Contributor

"This armor piercing (note: what ARE we doing with hyphenation/spacing/onewording?) cartridge uses a steel penetrator, and was first introduced in 1998."

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_ammo.json Outdated

  
                "name" : "6.54x42 casing",

                "symbol" : "=",

                "color" : "dark_gray",

                "description" : "An empty casing from a 6,54x42 round.",

KA101 Jan 31, 2014

Contributor

6.54x42. I've messed up my commas/periods too. ;-)

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_weapons.json Outdated

  
            "symbol": "(",

            "color": "dark_gray",

            "name": "SVS-24C",

            "description": "The compact version of the standard SVS-24. It is commonly issued to tank crews or special forces due to it's smaller size. The shorter barrel has some negative effects to the accuracy though.",

KA101 Jan 31, 2014

Contributor

Same problem with its. The shorter barrel reduces accuracy.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_weapons.json Outdated

  
            "symbol": "(",

            "color": "dark_gray",

            "name": "CW-24",

            "description": "Civilian version of the SVS-24. It was made by Clearwater Arms, Georgia for the market in the US. It's pure semi-automatic, but fires the same powerful cartridge as the SVS-24.",

KA101 Jan 31, 2014

Contributor

For the US market, surely.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_weapons.json Outdated

  
            "symbol": "(",

            "color": "light_gray",

            "name": "CW-24M",

            "description": "Civilian version of the SVS-24. This one fires the cheaper, but still powerful 5.45x39mm cartridge.",

KA101 Jan 31, 2014

Contributor

Needs a comma after "but still powerful", please.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/ew_weapons.json Outdated

  
            "symbol": "(",

            "color": "light_gray",

            "name": "CW-24K",

            "description": "Civilian version of the SVS-24. This one fires the cheaper, but still powerful 7.62x39mm cartridge.",

KA101 Jan 31, 2014

Contributor

Same here.

KA101 reviewed Jan 31, 2014

View changes

data/mods/EW_Pack/modinfo.json Outdated

  
        		"mod_type": "SUPPLEMENTAL",

        		"ident": "ew_pack",

        		"name": "Extended Weapons Pack",

        		"description": "For those gun nuts.",

KA101 Jan 31, 2014

Contributor

Indeed. ;-) Might want to make the name a bit more specific as folks might agree to make One Mega Gun-Pack at some point, though.


      Fixed the typos and edited the descriptions.

f1cc5f5

Contributor Author

redice99 commented Feb 1, 2014

Maybe they could include that mega weapon pack in this mod, so everything is in one folder.


      Fixed a typo and modified the descriptions once again.

73b15f8

Contributor

Lain- commented Feb 1, 2014

Nice job redice99! More mods is always welcomed.

KA101 added a commit that referenced this pull request Feb 2, 2014


      Merge pull request #5848 from redice99/ew_mod

Made mod that can be loaded through the mod manager.

cc0cc0a

KA101 merged commit `cc0cc0a` into CleverRaven:master Feb 2, 2014
1 check passed

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.