Overhaul sights' volumes #58588
Merged
Overhaul sights' volumes #58588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making them more realistic
github-actions
bot
added
[JSON]
|
For detailed holographic sight size see #53788 |
Maleclypse
reviewed
Jun 21, 2022
|
for a few of these it might be worth it to include a comment with a link / name for the model you used. So someone else doesn't come in, in 6 months and "Overhaul sights' volumes" again 😆 |
Drew4484
pushed a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
Jul 4, 2022
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Overhaul sights' volumes"
Purpose of change
Making them more realistic. Also fixes #53788
Describe the solution
Googling all the generic sights, preferably technical drawings, and eyeballing their volume.
Describe alternatives you've considered
Testing
Additional context