cata_tiles: More robust variant looks-like #58976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior of drawing variants for overlays would give up if a gendered overlay was not provided. This is wrong, so now try all the normal routes of finding an ungendered overlay, and trying for non-active mutations, before giving up. This essentially duplicates the logic below, but tries with a variant, whereas below it will not try with a variant because it is trying looks-like, which will not have variants matching the one of the drawn thing.
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The previous behavior of drawing variants for overlays would give up if a gendered overlay was not provided. This is wrong, so now try all the normal routes of finding an ungendered overlay, and try for non-active mutations, before giving up.
Describe the solution
This essentially duplicates the logic below, but tries with a variant, whereas below it will not try with a variant because it is trying looks-like, which will not have variants matching the one of the drawn thing.
Describe alternatives you've considered
Less duplication? Because mutations don't have variants, the active mutation section doesn't actually do anything (right now).
Testing
Get 3 items with variants.
Edit your tileset of choice, and replace some tile ids with
overlay_wieldedgender_id_var_variant,overlay_wieldedid_var_variant,overlay_wieldedid, check that each gun, when wielded, shows as the tile you defined for it.Additional context
Cherry-picked from #58669