Update newspapers.json #59031
Merged
Update newspapers.json #59031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On line 324, the text mentions "cybernetic superiority" which is not possible according to the current Lore where cybernetics wouldn't exist in pre-cataclysm times. This changes the text to instead mention "military" technology which is more lore friendly and feasible in the given context
github-actions
bot
added
[JSON]
Maleclypse
approved these changes
Jul 7, 2022
github-actions
bot
added
json-styled
|
Can some please explain why General Build Matrix 12 failed? All I did was change one json and the game runs fine on my own Windows computer |
|
We run a huge suite of tests on multiple builds, because of that huge suite sometimes the random numbers generated will be outside of the acceptable range of results. A test will then fail. Before merging someone will look and make sure it’s a random number failure and not a systemic failure. |
|
Ah ok, I was worried about what can of worms I managed to open with one json. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
In the newspaper snippet, on line 324, the text mentions "cybernetic superiority", which is not possible according to the current Lore where cybernetics wouldn't exist in pre-cataclysm times.
Describe the solution
Changes the text to instead mention "military superiority", which is more lore friendly and feasible in the given context
Describe alternatives you've considered
Testing
Opened the game after the change and looked at the same newspaper where I detected the lore clashing text. Change worked with no errors.
Additional context