Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upprevent vehicle turrets from attacking their own car #6016
Conversation
This comment has been minimized.
This comment has been minimized.
|
Uh, sorry, BevapDin. My armored car blew out its own headlight and steel plating shooting at soldier ants. Screencap: https://www.dropbox.com/s/ifq0ub6tmp2v9yz/02072014TurretsStillSelfDamage.PNG |
This comment has been minimized.
This comment has been minimized.
|
Fixed it, was checking for (tx,tx) not (tx,ty) and my test case contained tx == ty, so the bug did not appear to me. |
KA101
merged commit 47bf8f1
into
CleverRaven:master
Feb 8, 2014
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
|
Np. This'll make a lot of vehicle-users very happy. When GlyphGryph gets back, remind me to put you in for four-star. |
This comment has been minimized.
This comment has been minimized.
HunterAlpha1
commented
Feb 8, 2014
|
going to try it out now. |
BevapDin
deleted the
BevapDin:targeting-turrets
branch
Feb 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedFeb 8, 2014
Vehicle turrets use a fake npc to fire their gun. This PR adds checks for that fake creature and the vehicle they are on. It prevents calling
map::shootif this would damage the very same vehicle.This prevents certain code that damages the terrain/furniture from being executed, but the squares should not have any of theses terrain/furnitures, because driving the car onto that square should have already damaged the content.