Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid sawing non-existent pistol stocks #60497

Merged
merged 1 commit into from Aug 30, 2022
Merged

Forbid sawing non-existent pistol stocks #60497

merged 1 commit into from Aug 30, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Forbid sawing non-existent pistol stocks"

Purpose of change

Describe the solution

If gun is a pistol, forbid sawing its non-existent stock. Even if pistol has stock attached, like collapsing wire stock or pistol stock, I think it's safe to assume we don't want to saw it off.

Describe alternatives you've considered

None.

Testing

Got P-32, got bow saw. Activated bow saw. Checked that P-32 is a non-valid target.

Additional context

изображение

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Aug 27, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 27, 2022
@Fris0uman Fris0uman merged commit db12161 into CleverRaven:master Aug 30, 2022
@Night-Pryanik Night-Pryanik deleted the pistol-stocks branch August 30, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saw Off Pistol Stock???
2 participants
@Night-Pryanik @Fris0uman